[SERVER-49415] create_new_indexes_with_conflict.js hangs intermittently due to unreliable log line checking Created: 09/Jul/20  Updated: 29/Oct/23  Resolved: 24/Jul/20

Status: Closed
Project: Core Server
Component/s: Storage
Affects Version/s: None
Fix Version/s: 4.4.1, 4.7.0

Type: Bug Priority: Major - P3
Reporter: Benety Goh Assignee: Benety Goh
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
Related
related to SERVER-49837 add test for createIndexes command to... Closed
is related to SERVER-44405 Use MODE_IX lock for implicit collect... Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Requested:
v4.4
Sprint: Execution Team 2020-07-27
Participants:
Linked BF Score: 9

 Description   

TLDR: MODE_X collection access in IndexBuildsCoordinator::_filterSpecsAndRegisterBuild() is not compatible with second test case; and fix log message detection in test.

create_new_indexes_with_conflict.js runs two test cases using the same test function runConflictingCollectionCreate(). During the second test run, the test function may erroneously detect the log message from the first test run.

This issue may be resolved by using checkLog.containsWithCount() rather than checkLog.contains(); or by splitting up the test into two separate JS files. However, fixing the test itself exposes an issue with the second test case which runs an index build on an existing collection - the second test case will hang due to an exclusive lock in IndexBuildsCoordinator::_filterSpecsAndRegisterBuild() that conflicts with the fail point in create_indexes.cpp.



 Comments   
Comment by Githook User [ 04/Aug/20 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-49415 remove test case with conflicting index build

(cherry picked from commit 78cc027285359cc21c55f2dac69ce41cb9f23959)
Branch: v4.4
https://github.com/mongodb/mongo/commit/10976e18844d3a80b3567765ed06c30f63efbccd

Comment by Githook User [ 24/Jul/20 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-49415 remove test case with conflicting index build
Branch: master
https://github.com/mongodb/mongo/commit/78cc027285359cc21c55f2dac69ce41cb9f23959

Comment by Benety Goh [ 10/Jul/20 ]

We should also consider removing the creatingConflictingIndex=true test case if the exclusive lock is necessary for the _filterSpecsAndRegisterBuild()'s operation.

Comment by Benety Goh [ 09/Jul/20 ]

This test was introduced in SERVER-44405.

Generated at Thu Feb 08 05:19:47 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.