[SERVER-49427] Delete pending_chunk.js and remove now-defunct code in the MetadataManager Created: 10/Jul/20  Updated: 29/Oct/23  Resolved: 28/Jul/20

Status: Closed
Project: Core Server
Component/s: Sharding
Affects Version/s: None
Fix Version/s: 4.7.0

Type: Task Priority: Major - P3
Reporter: Blake Oler Assignee: Cheahuychou Mao
Resolution: Fixed Votes: 0
Labels: sharding-wfbf-day
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to SERVER-48192 investigate the failures in the targe... Closed
Backwards Compatibility: Fully Compatible
Sprint: Sharding 2020-07-27
Participants:
Linked BF Score: 0

 Description   

This test exercises pre-resumable range deleter behavior, and is now defunct. Note that we remove a very similar looking test as part of the test removal process for the resumable range deleter project in SERVER-47992.

Along with this, there is now unused code in the MetadataManager. Follow up with matthew.saltz to find out more.

Don't forget to remove these tests from blacklists as well.



 Comments   
Comment by Githook User [ 28/Jul/20 ]

Author:

{'name': 'Cheahuychou Mao', 'email': 'cheahuychou.mao@mongodb.com', 'username': 'cheahuychou'}

Message: SERVER-49427 Remove unused function declarations in MetadataManager and CollectionShardingRuntime
Branch: master
https://github.com/mongodb/mongo/commit/70e8825df3a7a6f3e6384312497c5b852d2d7f1a

Comment by Eric Milkie [ 27/Jul/20 ]

I forgot: the reason why I discovered this is because the Coverity build also uses the install-all target, but it differs from Evergreen builders in some ways.

Comment by Eric Milkie [ 27/Jul/20 ]

"install-all" is an SCons alias target for hygienic builds that replaces the "all" alias from legacy mode. "compile_all" is a task defined in evergreen.yml that contains the target "install-all", so local builds using install-all ought to be the same as Evergreen builders with the compile_all task. However, due to some still undiagnosed reason, the Evergreen builders of the compile_all task did not fail to link, even though they should have. Therefore, this is a trap that others could fall into the future, so I expect we'll try to figure out what happened in order to fix the trap.
Thanks for fixing this!

Comment by Eric Milkie [ 25/Jul/20 ]

/data/2/mongo: git grep beginReceive\(
src/mongo/db/s/collection_sharding_runtime.h:    SharedSemiFuture<void> beginReceive(ChunkRange const& range);
src/mongo/db/s/migration_util_test.cpp:    std::ignore = CollectionShardingRuntime::get(opCtx, nss)->beginReceive(range);

Comment by Eric Milkie [ 25/Jul/20 ]

This commit broke the install-all target, as there are still callers of beginReceive(ChunkRange const& range) you didn't remove.

Comment by Githook User [ 24/Jul/20 ]

Author:

{'name': 'Cheahuychou Mao', 'email': 'cheahuychou.mao@mongodb.com', 'username': 'cheahuychou'}

Message: SERVER-49427 Delete pending_chunk.js and remove now-defunct code in the MetadataManager
Branch: master
https://github.com/mongodb/mongo/commit/5e53ee3ca0a90eb98cdab94b298dec810fb46804

Generated at Thu Feb 08 05:19:49 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.