[SERVER-49693] Represent replicaSetPingTimeMillis in floating point Created: 17/Jul/20 Updated: 29/Oct/23 Resolved: 22/Jul/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 4.4.1, 4.7.0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Benjamin Caimano (Inactive) | Assignee: | Lamont Nelson |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Minor Change | ||||||||
| Backport Requested: |
v4.4
|
||||||||
| Participants: | |||||||||
| Description |
|
On replicaSetPingTimeMillis, we pipe it from here for every host we know about. However, IsMasterRTT is in Nanoseconds and replicaSetPingTimeMillis is in Milliseconds. Thus we can get 0 values consistently for colocated hosts and never represent certain hosts in FTDC. Thinking towards the future, we tend to represent time types in floating point for external users, and using floating point here would also make this clearer. |
| Comments |
| Comment by Githook User [ 04/Aug/20 ] |
|
Author: {'name': 'LaMont Nelson', 'email': 'lamont.nelson@mongodb.com', 'username': 'lamontnelson'}Message: (cherry picked from commit 26cca6d4dcabbeab572bc6dd88e25a683a4e11e7) |
| Comment by Githook User [ 22/Jul/20 ] |
|
Author: {'name': 'LaMont Nelson', 'email': 'lamont.nelson@mongodb.com', 'username': 'lamontnelson'}Message: |
| Comment by Lamont Nelson [ 22/Jul/20 ] |
|
The format for "pingTimeMillis" in the connPoolStats command was changed from a decimal to floating point. |
| Comment by Lamont Nelson [ 21/Jul/20 ] |