[SERVER-49703] Add alphabetic lib ordering libdep linter rule Created: 17/Jul/20 Updated: 29/Oct/23 Resolved: 27/Aug/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 4.7.0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Daniel Moody | Assignee: | Daniel Moody |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Sprint: | Dev Platform 2020-09-07 | ||||||||
| Participants: | |||||||||
| Description |
|
While working on |
| Comments |
| Comment by Githook User [ 27/Aug/20 ] | ||||||||
|
Author: {'name': 'Daniel Moody', 'email': 'daniel.moody@mongodb.com', 'username': 'dmoody256'}Message: | ||||||||
| Comment by Githook User [ 27/Aug/20 ] | ||||||||
|
Author: {'name': 'Daniel Moody', 'email': 'daniel.moody@mongodb.com', 'username': 'dmoody256'}Message: | ||||||||
| Comment by Andrew Morrow (Inactive) [ 24/Aug/20 ] | ||||||||
|
We should consider the build path, but we should not require it be listed. In other words, the following is correct, and what is commonly found today in the SConscript files:
I don't want to require use of $BUILD_DIR when something can be named shortly. | ||||||||
| Comment by Daniel Moody [ 24/Aug/20 ] | ||||||||
|
Should the ordering consider the BUILD path? or just the library name? we mostly do consider the build path currently.
If we do consider the build path, should it be required that the build path be listed for libraries set in LIBDEPS variables? |