[SERVER-49703] Add alphabetic lib ordering libdep linter rule Created: 17/Jul/20  Updated: 29/Oct/23  Resolved: 27/Aug/20

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 4.7.0

Type: Improvement Priority: Major - P3
Reporter: Daniel Moody Assignee: Daniel Moody
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to SERVER-48638 Enforce more rules for LIBDEPS Closed
Backwards Compatibility: Fully Compatible
Sprint: Dev Platform 2020-09-07
Participants:

 Description   

While working on SERVER-48638, it was noted that a libdep linter rule could be created to made sure the ordering of the libdeps was alphabetic.



 Comments   
Comment by Githook User [ 27/Aug/20 ]

Author:

{'name': 'Daniel Moody', 'email': 'daniel.moody@mongodb.com', 'username': 'dmoody256'}

Message: SERVER-49703 Added libdep linter alphabetic rule and update all libdeps list to be alphabetical
Branch: master
https://github.com/mongodb/mongo/commit/ad84ed6435d49b86bd6f97c530131c094cc6122c

Comment by Githook User [ 27/Aug/20 ]

Author:

{'name': 'Daniel Moody', 'email': 'daniel.moody@mongodb.com', 'username': 'dmoody256'}

Message: SERVER-49703 updated libdates to alphabetic ordering for new linter rule.
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/99aeab0eae115874842d5f134387b6380cda7c17

Comment by Andrew Morrow (Inactive) [ 24/Aug/20 ]

We should consider the build path, but we should not require it be listed. In other words, the following is correct, and what is commonly found today in the SConscript files:

LIBDEPS=[
    '$BUILD_DIR/a',
    '$BUILD_DIR/b',
    '$BUILD_DIR/c',
    'a',
    'b',
    'c',
]

I don't want to require use of $BUILD_DIR when something can be named shortly.

Comment by Daniel Moody [ 24/Aug/20 ]

Should the ordering consider the BUILD path? or just the library name? we mostly do consider the build path currently.

 

If we do consider the build path, should it be required that the build path be listed for libraries set in LIBDEPS variables?

Generated at Thu Feb 08 05:20:35 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.