[SERVER-49759] Destruct AuthorizationManager on shutdown Created: 21/Jul/20 Updated: 30/Jul/20 Resolved: 30/Jul/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Sharding |
| Affects Version/s: | 4.5.1, 4.2.8, 4.4.0-rc13 |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Minor - P4 |
| Reporter: | Tommaso Tocci | Assignee: | Mark Benvenuto |
| Resolution: | Duplicate | Votes: | 0 |
| Labels: | thread-sanitizer | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||||||
| Issue Links: |
|
||||||||||||
| Operating System: | ALL | ||||||||||||
| Sprint: | Security 2020-08-10 | ||||||||||||
| Participants: | |||||||||||||
| Linked BF Score: | 0 | ||||||||||||
| Description |
|
The AuthorizationManager is a service context decorator and is constructed using ConstructorActionRegisterer but is never destructed. The goal of this ticket is to add a DestructorAction that destructs the AuthorizationManager on shutdown. |
| Comments |
| Comment by Mark Benvenuto [ 30/Jul/20 ] |
|
Yes, |
| Comment by Andrew Morrow (Inactive) [ 29/Jul/20 ] |
|
So perhaps this should be re-closed and the BF made to block on |
| Comment by Tommaso Tocci [ 29/Jul/20 ] |
|
Yes, doing a clean shutdown and perform all the current DestructorAction should be enough to fix BF-18230 |
| Comment by Andrew Morrow (Inactive) [ 29/Jul/20 ] |
|
mark.benvenuto - Would fixing |
| Comment by Mark Benvenuto [ 29/Jul/20 ] |
|
I am reopening it this issue because it is still responsible for the failures in BF-18230 because it is not destroyed on shutdown. |
| Comment by Tommaso Tocci [ 24/Jul/20 ] |
|
The DestructorAction is actually instantiated here. So no need of doing this. |
| Comment by Tommaso Tocci [ 21/Jul/20 ] |