[SERVER-49881] remove noop std::move from CollectionCatalog::setCollectionNamespace() rollback handler Created: 24/Jul/20  Updated: 27/Oct/23  Resolved: 28/Oct/20

Status: Closed
Project: Core Server
Component/s: Storage
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Minor - P4
Reporter: Benety Goh Assignee: Backlog - Storage Execution Team
Resolution: Gone away Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to SERVER-49800 add use-after-move rule to clang-tidy... Closed
is related to SERVER-50145 Have DDL operations and MODE_X writer... Closed
Assigned Teams:
Storage Execution
Participants:

 Description   

This std::move in the RecoveryUnit rollback handler has no effect on the movable type NamespaceString 'fromCollection' because 'fromCollection' is captured as a const variable in the lambda. In addition to removing the confusing std::move, this would also be a good opportunity to add some unit test coverage for the rollback handler.



 Comments   
Comment by Benety Goh [ 28/Oct/20 ]

Rollback handler referenced in the description was removed in SERVER-50145.

Generated at Thu Feb 08 05:21:06 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.