[SERVER-49926] [4.4] collMod should not accept "recordPreImages: false" option in FCV 4.2 Created: 27/Jul/20  Updated: 29/Oct/23  Resolved: 09/Sep/20

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 4.4.2

Type: Bug Priority: Major - P3
Reporter: Louis Williams Assignee: Dianna Hohensee (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Execution Team 2020-09-07, Execution Team 2020-09-21
Participants:
Linked BF Score: 0

 Description   

Passing "recordPreImages: false" to collMod can still replicate an unknown field to 4.2 secondaries.

This is because we do not attempt to set the option when the field is already 'false'. This, however also bypasses validation in validatePreImageRecording.

This is a follow-up to SERVER-48971, which did not completely address the problem.



 Comments   
Comment by Githook User [ 09/Sep/20 ]

Author:

{'name': 'Dianna Hohensee', 'email': 'dianna.hohensee@mongodb.com', 'username': 'DiannaHohensee'}

Message: SERVER-49926 collMod should always validate the 'recordPreImages' user parameter
Branch: v4.4
https://github.com/mongodb/mongo/commit/81b55eb3f23806a36d300bd5de3bff89fcfdca2f

Comment by Louis Williams [ 30/Jul/20 ]

We should either always call setRecordPreImages regardless of input, or differentiate between a 'recordPreImages: false' input and one where the field is absent (with a boost::optional?).

Generated at Thu Feb 08 05:21:14 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.