[SERVER-49950] Address issues with ClockSource::setAlarm() and ClockSourceMock::_processAlarms() Created: 28/Jul/20  Updated: 29/Oct/23  Resolved: 25/Feb/22

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 6.0.0-rc0

Type: Bug Priority: Major - P3
Reporter: Benjamin Caimano (Inactive) Assignee: Amirsaman Memaripour
Resolution: Fixed Votes: 0
Labels: servicearch-wfbf-day
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Duplicate
is duplicated by SERVER-63103 ClockSourceMock::get has no implement... Closed
Related
related to SERVER-64000 Create a unlock/relock scope guard Closed
is related to SERVER-48650 Unit tests' ServiceContext's NetworkI... Closed
Backwards Compatibility: Fully Compatible
Sprint: Service Arch 2022-03-07
Participants:
Story Points: 2

 Description   

ClockSource::setAlarm() is only used in testing code here and here. The function itself might be more effective in a different form since it always deviates the code flow from the normal behavior. The function as is should probably be converted to throw instead of return a status. In addition, ClockSourceMock has issues with its implementation that might launch alarms out of order.



 Comments   
Comment by Githook User [ 25/Feb/22 ]

Author:

{'name': 'Saman Memaripour', 'email': 'amirsaman.memaripour@mongodb.com', 'username': 'samanca'}

Message: SERVER-49950 Refactor and fix `ClockSourceMock`
Branch: master
https://github.com/mongodb/mongo/commit/c7725c7cd74d1cb9c62134401f05cb91174d1a04

Comment by Billy Donahue [ 27/Jan/22 ]

Unclear why this was closed. It shouldn't be necessary for reporters to spontaneously re-ping tickets to keep them open. The reporter is (Inactive) and can't be expected to do so in any case.

The description describes an important flaw in ClockSourceMock that came up in a review. https://mongodbcr.appspot.com/634300004/#msg7

"ClockSourceMock has issues with its implementation that might launch alarms out of order."

Comment by Lauren Lewis (Inactive) [ 21/Dec/21 ]

We haven’t heard back from you in at least 1 year, so I'm going to close this ticket. If this is still an issue for you, please provide additional information and we will reopen the ticket.

Generated at Thu Feb 08 05:21:18 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.