[SERVER-50078] Compile bypass applied when it should not have Created: 03/Aug/20  Updated: 29/Oct/23  Resolved: 12/Aug/20

Status: Closed
Project: Core Server
Component/s: Build
Affects Version/s: None
Fix Version/s: 4.4.1, 4.7.0, 4.2.10, 4.0.21

Type: Bug Priority: Major - P3
Reporter: Andrew Morrow (Inactive) Assignee: David Bradford (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Related
related to SERVER-69268 Disable bypass compile during burn_in... Closed
related to SERVER-50087 Provide a way to disable compile bypa... Closed
is related to SERVER-24689 Support automatic compile bypass for ... Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Requested:
v4.4, v4.2, v4.0
Sprint: DAG 2020-08-24
Participants:
Story Points: 2

 Description   

See dev-only comment with patch build links, but as far as I understand it, changes to SConstruct should disable compile bypass.

See also EVG-12714.



 Comments   
Comment by Githook User [ 12/Aug/20 ]

Author:

{'name': 'David Bradford', 'email': 'david.bradford@mongodb.com', 'username': 'dbradf'}

Message: SERVER-50078: Disable bypass_compile

(cherry picked from commit b1d88bac122fcadedcb0be3798872770de9c732a)
(cherry picked from commit 4a23cd035cc14fe281f265e7d42b032f9ca8434f)
(cherry picked from commit 1f3af36a3663a6b85fec18a14dab756a54574243)
Branch: v4.0
https://github.com/mongodb/mongo/commit/b664d3bf5ab7642b9a0ef3289e666ed1043572e9

Comment by Githook User [ 12/Aug/20 ]

Author:

{'name': 'David Bradford', 'email': 'david.bradford@mongodb.com', 'username': 'dbradf'}

Message: SERVER-50078: Disable bypass_compile

(cherry picked from commit b1d88bac122fcadedcb0be3798872770de9c732a)
(cherry picked from commit 4a23cd035cc14fe281f265e7d42b032f9ca8434f)
Branch: v4.2
https://github.com/mongodb/mongo/commit/1f3af36a3663a6b85fec18a14dab756a54574243

Comment by Githook User [ 12/Aug/20 ]

Author:

{'name': 'David Bradford', 'email': 'david.bradford@mongodb.com', 'username': 'dbradf'}

Message: SERVER-50078: Disable bypass_compile

(cherry picked from commit b1d88bac122fcadedcb0be3798872770de9c732a)
Branch: v4.4
https://github.com/mongodb/mongo/commit/4a23cd035cc14fe281f265e7d42b032f9ca8434f

Comment by Githook User [ 12/Aug/20 ]

Author:

{'name': 'David Bradford', 'email': 'david.bradford@mongodb.com', 'username': 'dbradf'}

Message: SERVER-50078: Disable bypass_compile
Branch: master
https://github.com/mongodb/mongo/commit/b1d88bac122fcadedcb0be3798872770de9c732a

Comment by David Bradford (Inactive) [ 12/Aug/20 ]

I see what is happening. The changes are being applied to the patch build differently than they used to be. So when bypass_compile looks at what files have changed, it is getting an empty list which makes it think it is safe to bypass_compile. For the short-term, I am going to just disable bypass_compile.

Longer-term, I think having the user specify they want bypass_compile enabled when submitting their patch build makes the most sense. Having bypass_compile for things like test-only changes can save a lot of time, but bugs in the scripts are causing unacceptable mistakes. For this, we would likely need something like parameterized builds in Evergreen.

Comment by Brooke Miller [ 07/Aug/20 ]

If this becomes more complex, we should consider ticketing this work out further.

Generated at Thu Feb 08 05:21:39 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.