[SERVER-50078] Compile bypass applied when it should not have Created: 03/Aug/20 Updated: 29/Oct/23 Resolved: 12/Aug/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Build |
| Affects Version/s: | None |
| Fix Version/s: | 4.4.1, 4.7.0, 4.2.10, 4.0.21 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Andrew Morrow (Inactive) | Assignee: | David Bradford (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||
| Operating System: | ALL | ||||||||||||||||||||
| Backport Requested: |
v4.4, v4.2, v4.0
|
||||||||||||||||||||
| Sprint: | DAG 2020-08-24 | ||||||||||||||||||||
| Participants: | |||||||||||||||||||||
| Story Points: | 2 | ||||||||||||||||||||
| Description |
|
See dev-only comment with patch build links, but as far as I understand it, changes to SConstruct should disable compile bypass. See also |
| Comments |
| Comment by Githook User [ 12/Aug/20 ] |
|
Author: {'name': 'David Bradford', 'email': 'david.bradford@mongodb.com', 'username': 'dbradf'}Message: (cherry picked from commit b1d88bac122fcadedcb0be3798872770de9c732a) |
| Comment by Githook User [ 12/Aug/20 ] |
|
Author: {'name': 'David Bradford', 'email': 'david.bradford@mongodb.com', 'username': 'dbradf'}Message: (cherry picked from commit b1d88bac122fcadedcb0be3798872770de9c732a) |
| Comment by Githook User [ 12/Aug/20 ] |
|
Author: {'name': 'David Bradford', 'email': 'david.bradford@mongodb.com', 'username': 'dbradf'}Message: (cherry picked from commit b1d88bac122fcadedcb0be3798872770de9c732a) |
| Comment by Githook User [ 12/Aug/20 ] |
|
Author: {'name': 'David Bradford', 'email': 'david.bradford@mongodb.com', 'username': 'dbradf'}Message: |
| Comment by David Bradford (Inactive) [ 12/Aug/20 ] |
|
I see what is happening. The changes are being applied to the patch build differently than they used to be. So when bypass_compile looks at what files have changed, it is getting an empty list which makes it think it is safe to bypass_compile. For the short-term, I am going to just disable bypass_compile. Longer-term, I think having the user specify they want bypass_compile enabled when submitting their patch build makes the most sense. Having bypass_compile for things like test-only changes can save a lot of time, but bugs in the scripts are causing unacceptable mistakes. For this, we would likely need something like parameterized builds in Evergreen. |
| Comment by Brooke Miller [ 07/Aug/20 ] |
|
If this becomes more complex, we should consider ticketing this work out further. |