[SERVER-50097] inaccurate exhaustIsMasterMetrics if an isMaster command alias is used Created: 04/Aug/20  Updated: 29/Oct/23  Resolved: 05/Aug/20

Status: Closed
Project: Core Server
Component/s: Replication
Affects Version/s: 4.5 Required
Fix Version/s: 4.7.0, 4.4.2

Type: Bug Priority: Major - P3
Reporter: Pavithra Vetriselvan Assignee: Pavithra Vetriselvan
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
is depended on by SERVER-49986 Convert isMaster command to hello and... Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Requested:
v4.4
Sprint: Repl 2020-08-10
Participants:

 Description   

The exhaust isMaster metrics rely on the command name when keeping track of exhaust isMaster requests.

On mongod, we search the command registry for the command name specified in the request object. This ensures that aliases like "ismaster" are properly covered in the exhaust isMaster metrics.

On mongos, however, we only look at the command name passed into the request. This means that we will incorrectly mark inExhaustIsMaster as false if we send "ismaster" instead of "isMaster" to mongos.

Mongos should look up the request's command name in the command registry so that any aliases to the isMaster command are correctly covered.



 Comments   
Comment by Githook User [ 09/Sep/20 ]

Author:

{'name': 'Pavi Vetriselvan', 'email': 'pavithra.vetriselvan@mongodb.com', 'username': 'pvselvan'}

Message: SERVER-50097 isMaster aliases should correctly populate exhaustIsMasterMetrics

(cherry picked from commit 9e4b6e5c2f9e266ed05ce7c913631f12548e4160)
Branch: v4.4
https://github.com/mongodb/mongo/commit/137858b32e8a81d681e8a5e92845424671c8da36

Comment by Githook User [ 05/Aug/20 ]

Author:

{'name': 'Pavi Vetriselvan', 'email': 'pavithra.vetriselvan@mongodb.com', 'username': 'pvselvan'}

Message: SERVER-50097 isMaster aliases should correctly populate exhaustIsMasterMetrics
Branch: master
https://github.com/mongodb/mongo/commit/9e4b6e5c2f9e266ed05ce7c913631f12548e4160

Generated at Thu Feb 08 05:21:42 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.