[SERVER-50131] Extend SorterTests to cover constructing a NoLimitSorter from existing ranges Created: 05/Aug/20  Updated: 29/Oct/23  Resolved: 30/Sep/20

Status: Closed
Project: Core Server
Component/s: Storage
Affects Version/s: None
Fix Version/s: 4.8.0

Type: Improvement Priority: Major - P3
Reporter: Gregory Noma Assignee: Benety Goh
Resolution: Fixed Votes: 0
Labels: pm-1344, techdebt
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to SERVER-49408 adjust startup to resume index build ... Closed
is related to SERVER-49244 write JS test to ensure internal iden... Closed
Backwards Compatibility: Fully Compatible
Sprint: Execution Team 2020-10-05
Participants:

 Description   

To support resumable index builds, we overloaded the Sorter constructor in SERVER-49408 to accept a list of existing ranges. It would be beneficial to extend C++ unit test coverage to include this new code path.

There is existing test coverage provided by resumable_index_build_bulk_load_phase.js added in SERVER-49244.



 Comments   
Comment by Githook User [ 30/Sep/20 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-50131 add tests for constructing Sorter from existing ranges
Branch: master
https://github.com/mongodb/mongo/commit/25beba702528e9dfec59f9bf2d1d66e8e7cda657

Comment by Githook User [ 29/Sep/20 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-50131 make EncryptionHooks check in Sorter work with tests without service context
Branch: master
https://github.com/mongodb/mongo/commit/eb2b72cf9c0269f086223d499ac9be8a270d268c

Comment by Githook User [ 29/Sep/20 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-50131 fix typo in Sorter::makeFromExistingRanges() invariant message
Branch: master
https://github.com/mongodb/mongo/commit/f7cf4c24dc58d3145388771fb12e03671055e863

Comment by Githook User [ 29/Sep/20 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-50131 fix header includes and using directives in sorter_test.cpp
Branch: master
https://github.com/mongodb/mongo/commit/1399e3ad7248ceb191dfbced2fb785a4a4170f63

Generated at Thu Feb 08 05:21:49 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.