[SERVER-50141] ServiceStateMachineTest needs to be rewritten Created: 06/Aug/20  Updated: 29/Oct/23  Resolved: 05/Feb/21

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 4.9.0

Type: Improvement Priority: Major - P3
Reporter: Benjamin Caimano (Inactive) Assignee: Benjamin Caimano (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on SERVER-53420 Make transport Session source/sink/po... Closed
depends on SERVER-53421 Provide ways to track Session cleanup Closed
depends on SERVER-53426 Allow ServiceStateMachine to cleanup ... Closed
Related
related to SERVER-54510 Bind ClientStrand before destroying i... Closed
related to SERVER-52731 Make StatusWith types/constants inline Closed
related to SERVER-54143 Convert ServiceEntryPointImpl to Ingr... Open
is related to SERVER-49104 Futurize ServiceStateMachine transitions Closed
Backwards Compatibility: Fully Compatible
Sprint: Service Arch 2020-08-24, Service arch 2020-09-07, Service arch 2020-11-02, Service arch 2020-11-16, Service arch 2020-11-30, Service arch 2020-12-28, Service Arch 2021-01-25, Security 2021-01-25, Security 2021-02-08
Participants:

 Description   

ServiceStateMachineTest here relies heavily on a _runNext function that forces the ServiceStateMachine API to use unified delegator function for each state transition. We should rewrite the tests to use failpoint[s] to better model practice in use. We should also expand the test cases to cover a more complete set of cases.



 Comments   
Comment by Githook User [ 05/Feb/21 ]

Author:

{'name': 'Ben Caimano', 'email': 'ben.caimano@10gen.com'}

Message: SERVER-50141 Rewrite ServiceStateMachineTest
Branch: master
https://github.com/mongodb/mongo/commit/6ad265f0382f39c25ebadbdca2000ef71af961a8

Comment by Githook User [ 05/Feb/21 ]

Author:

{'name': 'Ben Caimano', 'email': 'ben.caimano@10gen.com'}

Message: SERVER-50141 Destroy OperationContext explicitly after sink
Branch: master
https://github.com/mongodb/mongo/commit/7378eaed9f0bd1d63f5e1339965e76fc1e2b4e6a

Generated at Thu Feb 08 05:21:51 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.