[SERVER-50168] Transition to rollback doesn't need to clear out the majority committed snapshot's timestamp. Created: 06/Aug/20  Updated: 29/Oct/23  Resolved: 02/Sep/20

Status: Closed
Project: Core Server
Component/s: Replication
Affects Version/s: None
Fix Version/s: 4.7.0

Type: Task Priority: Major - P3
Reporter: Suganthi Mani Assignee: Tess Avitabile (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
is depended on by SERVER-49075 Add replica_sets suite to resumable i... Closed
is depended on by SERVER-49774 Enable rollback testing for resumable... Closed
Backwards Compatibility: Fully Compatible
Backport Requested:
v4.4
Sprint: Repl 2020-09-07
Participants:

 Description   

Currently, when we transition to rollback we clear out the majority committed snapshot value maintained in replication coordinator and by the WT engine's snapshot manager. And, I think that's really unnecessary due to below points.
1) Rollback common point can only be >= majority committed snapshot value (applies both to EMRC false and true)
2) For EMRC= true case, when recoverToStableTimestamp() is called no other read or write operations can be performed as recoverToStableTimestamp is performed under global X lock

Also, the comment mentioned here looks stale as things have changed a lot after this commit (which drops the usage of named snapshots). ( Note: as part of this ticket we should also update _dropAllSnapshots_inlock() to something what it actually does - clearMajorityCommittedTimestamp()).



 Comments   
Comment by Githook User [ 02/Sep/20 ]

Author:

{'name': 'Tess Avitabile', 'email': 'tess.avitabile@mongodb.com', 'username': 'tessavitabile'}

Message: SERVER-50168 Stop clearing current committed snapshot after rollback
Branch: master
https://github.com/mongodb/mongo/commit/dce47dd519a2c5d4bce2264ad0a008e2927e2bba

Generated at Thu Feb 08 05:21:57 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.