[SERVER-50188] Have multiple resmoke setParameters cope with identical key/value pairs Created: 07/Aug/20  Updated: 29/Oct/23  Resolved: 10/Aug/20

Status: Closed
Project: Core Server
Component/s: Testing Infrastructure
Affects Version/s: None
Fix Version/s: 4.7.0

Type: Bug Priority: Major - P3
Reporter: Daniel Gottlieb (Inactive) Assignee: Daniel Gottlieb (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to SERVER-47509 resmoke accepts multiple "mongodSetPa... Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: STM 2020-08-24
Participants:

 Description   

When burn_in_tests are generated, the suites resmoke args are returned by the burn-in tests API call and can be duplicated in the resmoke command line invocation. For example, when the following test:

            "name": "burn_in:noPassthrough_1_enterprise-rhel-62-64-bit-resumable-index-builds",
            "commands": [
                {
                    "func": "do setup"
                },
                {
                    "func": "run tests",
                    "vars": {
                        "resmoke_args": "--suites=no_passthrough --storageEngine=wiredTiger --mongodSetParameters=\"{enableResumableIndexBuilds: true}\" --excludeWithAnyTags=resumable_index_build_incompatible  --repeatTestsSecs=600  --repeatTestsMin=2  --repeatTestsMax=1000  jstests/noPassthrough/resumable_index_build_drain_writes_phase_primary.js"
                    }
                }
            ],

is run in the resumable index builds buildvariant, the "enableResumableIndexBuilds: true" gets added once for the variant, and once from the API response.

Given this, it's not obvious whether variants should be including burn-in tests (assuming the enterprise rhel 6.2 builder is expected to be the canonical runner of burn-in tests).

However, it's a simple enough change to have resmoke cope with identical key/value pairs until the burn-in tests behavior is better understood.



 Comments   
Comment by Githook User [ 10/Aug/20 ]

Author:

{'name': 'Daniel Gottlieb', 'email': 'daniel.gottlieb@mongodb.com', 'username': 'dgottlieb'}

Message: SERVER-50188: Allow multiple setParameters for the same key if their value is also identical.
Branch: master
https://github.com/mongodb/mongo/commit/d774ce166fc451274c518253007e825810de4e04

Generated at Thu Feb 08 05:22:01 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.