[SERVER-50206] Remove "NoReload" ShardRegistry lookup functions Created: 10/Aug/20  Updated: 26/Oct/23

Status: Blocked
Project: Core Server
Component/s: Sharding
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Major - P3
Reporter: Kevin Pulo Assignee: Backlog - Catalog and Routing
Resolution: Unresolved Votes: 0
Labels: oldshardingemea, shardingemea-qw, shardregistry-consistency-bug
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on SERVER-72884 Remove usages of non causally consist... Open
depends on SERVER-67912 Reduce set of non-causally consistent... Closed
depends on SERVER-67914 Remove ShardRegistry::_getShardForRSN... Closed
Related
related to SERVER-57280 ShardRegistry must be initialized bef... Closed
related to SERVER-46202 Implement ShardRegistry on top of Rea... Closed
Assigned Teams:
Catalog and Routing
Sprint: Sharding EMEA 2022-09-19, Sharding EMEA 2022-10-03, Sharding EMEA 2022-10-17, Sharding EMEA 2022-10-31, Sharding EMEA 2022-11-14, Sharding EMEA 2022-11-28, Sharding EMEA 2022-12-12, Sharding EMEA 2022-12-26, Sharding EMEA 2023-01-09
Participants:
Story Points: 3

 Description   

After the ShardRegistry is made causally consistent in SERVER-46202, there should ideally no longer be any need for places to call the (non-causally consistent) getShardNoReload() method (and the other "NoReload" methods). We should clean up the call sites using these, and convert them to using the non-"NoReload" variants instead. This might require plumbing through opCtx (since getShard requires opCtx, but getShardNoReload doesn't), and also being careful to avoid any problems with getShard blocking (which getShardNoReload never does).



 Comments   
Comment by Tommaso Tocci [ 16/Jan/23 ]

I've removed all the non causally consistent accessors of the ShardRegistry except for getShardForHostNoReload. The work to remove this last one is tracked under SERVER-72884

Generated at Thu Feb 08 05:22:03 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.