[SERVER-50344] Rename Client::setSystemOperationKillable and Client::shouldKillSystemOperation Created: 17/Aug/20  Updated: 29/Oct/23  Resolved: 25/Aug/20

Status: Closed
Project: Core Server
Component/s: Replication
Affects Version/s: None
Fix Version/s: 4.7.0

Type: Task Priority: Major - P3
Reporter: Spencer Brody (Inactive) Assignee: Spencer Brody (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to SERVER-49238 Ensure that OpCtxs created by running... Closed
Backwards Compatibility: Fully Compatible
Sprint: Service Arch 2020-08-24, Service arch 2020-09-07
Participants:

 Description   

The names of these methods makes it seem like they control whether this Client thread is allowed to be killed by things such as killOp, when in reality they control whether the thread can be killed during stepUp. We should make the actual behavior clear from the name and comments.



 Comments   
Comment by Githook User [ 25/Aug/20 ]

Author:

{'name': 'Spencer T Brody', 'email': 'spencer@mongodb.com', 'username': 'stbrody'}

Message: SERVER-50344 Rename Client methods to clarify that they are about being killed during stepdown
Branch: master
https://github.com/mongodb/mongo/commit/20169d980a7eb60b4ef675cafab70be2c6a80e46

Comment by Spencer Brody (Inactive) [ 17/Aug/20 ]

Perhaps 'setSystemOperationKillableByStepdown' and 'canKillSystemOperationInStepdown'?

Generated at Thu Feb 08 05:22:25 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.