[SERVER-50375] Ensure mongos forwards API parameters from client request to shards Created: 18/Aug/20  Updated: 29/Oct/23  Resolved: 06/Oct/20

Status: Closed
Project: Core Server
Component/s: Replication
Affects Version/s: None
Fix Version/s: 4.9.0

Type: Task Priority: Major - P3
Reporter: A. Jesse Jiryu Davis Assignee: A. Jesse Jiryu Davis
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Problem/Incident
causes SERVER-52748 mongos incorrectly reports "Only the ... Closed
Backwards Compatibility: Fully Compatible
Sprint: Repl 2020-09-07, Repl 2020-09-21, Repl 2020-10-05, Repl 2020-10-19
Participants:
Linked BF Score: 39

 Comments   
Comment by Githook User [ 05/Oct/20 ]

Author:

{'name': 'A. Jesse Jiryu Davis', 'email': 'jesse@mongodb.com', 'username': 'ajdavis'}

Message: SERVER-50375 Ensure mongos forwards API parameters to shards, try 3
Branch: master
https://github.com/mongodb/mongo/commit/99e27ba5943fd561242ae0f90e263e9a4098036e

Comment by Githook User [ 02/Oct/20 ]

Author:

{'name': 'A. Jesse Jiryu Davis', 'email': 'jesse@mongodb.com', 'username': 'ajdavis'}

Message: Revert "SERVER-50375 Ensure mongos forwards API parameters to shards"

This reverts commit 9b8d4c2f029e2384fa769014c00091e4de362ea4.
Branch: master
https://github.com/mongodb/mongo/commit/01cac19578f0d65bdb8784892f078f7a004efa57

Comment by A. Jesse Jiryu Davis [ 02/Oct/20 ]

I'm reverting Try 2 since it also caused a BF. Two test-configuration YAML files refer to a test by the wrong name.

Comment by Githook User [ 02/Oct/20 ]

Author:

{'name': 'A. Jesse Jiryu Davis', 'email': 'jesse@mongodb.com', 'username': 'ajdavis'}

Message: SERVER-50375 Ensure mongos forwards API parameters to shards
Branch: master
https://github.com/mongodb/mongo/commit/9b8d4c2f029e2384fa769014c00091e4de362ea4

Comment by Githook User [ 01/Oct/20 ]

Author:

{'name': 'Tommaso Tocci', 'email': 'tommaso.tocci@mongodb.com', 'username': 'toto-dev'}

Message: Revert "SERVER-50375 Thoroughly test that mongos forwards API parameters"

This reverts commit e66093f0a8ee3cd95dea9480028a6da814bb1854.
Branch: master
https://github.com/mongodb/mongo/commit/f880b32be6c6081ca0eb6599fd14b8fad5a5813c

Comment by A. Jesse Jiryu Davis [ 01/Oct/20 ]

Reverted due to a test failure in kill_sessions.js, I'm investigating.

Comment by Githook User [ 01/Oct/20 ]

Author:

{'name': 'A. Jesse Jiryu Davis', 'email': 'jesse@mongodb.com', 'username': 'ajdavis'}

Message: SERVER-50375 Thoroughly test that mongos forwards API parameters
Branch: master
https://github.com/mongodb/mongo/commit/e66093f0a8ee3cd95dea9480028a6da814bb1854

Comment by A. Jesse Jiryu Davis [ 15/Sep/20 ]

Reopening. I want to convert my test, mongos_forwards_api_parameters_to_shards.js, to the much more thorough style of database_versioning_all_commands.js. This may catch bugs in the current implementation, and it will force us to consider API parameters for new commands that are added to mongos in the future.

Comment by A. Jesse Jiryu Davis [ 15/Sep/20 ]

Downstream changes are covered by the overall epic.

Comment by Githook User [ 10/Sep/20 ]

Author:

{'name': 'A. Jesse Jiryu Davis', 'email': 'jesse@mongodb.com', 'username': 'ajdavis'}

Message: SERVER-50375 Ensure mongos forwards API params to shards
Branch: master
https://github.com/mongodb/mongo/commit/74c76f296cfe3e6c2943d248bec49c84c0ea5b96

Comment by Githook User [ 26/Aug/20 ]

Author:

{'name': 'A. Jesse Jiryu Davis', 'email': 'jesse@mongodb.com', 'username': 'ajdavis'}

Message: SERVER-50375 APIParameters fields are boost::optional
Branch: master
https://github.com/mongodb/mongo/commit/ced82bf3ffbd16d775e21127c0905ef8633dc1b1

Comment by Githook User [ 25/Aug/20 ]

Author:

{'name': 'A. Jesse Jiryu Davis', 'email': 'jesse@mongodb.com', 'username': 'ajdavis'}

Message: Revert "SERVER-49858 Don't forward API params from drop/dropDatabase to config servers"

This reverts commit f4ed96b5a788003322a2dc36b46063475a0b36ca.

For SERVER-50375 we must forward API parameters from mongos commands to
shard commands, so commit f4ed96b5 was, in retrospect, a step in the
wrong direction.
Branch: master
https://github.com/mongodb/mongo/commit/152ea482d58e610e12539cec0be3c4f03e30a213

Generated at Thu Feb 08 05:22:29 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.