[SERVER-50376] Ninja next does not see compiler changes Created: 18/Aug/20 Updated: 29/Oct/23 Resolved: 22/Sep/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 4.8.0, 4.4.2 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Daniel Moody | Assignee: | Daniel Moody |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||
| Issue Links: |
|
||||
| Backwards Compatibility: | Fully Compatible | ||||
| Operating System: | ALL | ||||
| Backport Requested: |
v4.4
|
||||
| Steps To Reproduce: | reproduced on master commit: 2506e90e792f9dce299028d532fbabb48a44b556
Reproduces on Ubuntu 18.04 virtual workstation
Steps to reproduce:
|
||||
| Sprint: | Dev Platform 2020-09-07, Dev Platform 2020-09-21, Dev Platform 2020-10-05 | ||||
| Participants: | |||||
| Description |
|
Doing a ninja build, and changing the under lying compiler does not cause a rebuild when just reinvoking with ninja. |
| Comments |
| Comment by Githook User [ 13/Oct/20 ] | ||||||||||||||||
|
Author: {'name': 'Ryan Egesdahl', 'email': 'ryan.egesdahl@mongodb.com', 'username': 'deriamis'}Message: Merging the following fixes into the stable version of the build tools
(cherry picked from commit 78bb3f3c8a658a5a9fec8d55864e426382f68bd0) | ||||||||||||||||
| Comment by Githook User [ 09/Oct/20 ] | ||||||||||||||||
|
Author: {'name': 'Daniel Moody', 'email': 'daniel.moody@mongodb.com', 'username': 'dmoody256'}Message: (cherry picked from commit 9a2d87bdd45c5a89af147308e03121b0e4ef9a83) | ||||||||||||||||
| Comment by Githook User [ 07/Oct/20 ] | ||||||||||||||||
|
Author: {'name': 'Ryan Egesdahl', 'email': 'ryan.egesdahl@mongodb.com', 'username': 'deriamis'}Message: Merging the following fixes into the stable version of the build tools
(cherry picked from commit 78bb3f3c8a658a5a9fec8d55864e426382f68bd0) | ||||||||||||||||
| Comment by Githook User [ 06/Oct/20 ] | ||||||||||||||||
|
Author: {'name': 'Ryan Egesdahl', 'email': 'ryan.egesdahl@mongodb.com', 'username': 'deriamis'}Message: Merging the following fixes into the stable version of the build tools | ||||||||||||||||
| Comment by Githook User [ 21/Sep/20 ] | ||||||||||||||||
|
Author: {'name': 'Daniel Moody', 'email': 'daniel.moody@mongodb.com', 'username': 'dmoody256'}Message: (cherry picked from commit 6cddc81cc79964a10161b95b5c9702cda1afa2c1) | ||||||||||||||||
| Comment by Githook User [ 21/Sep/20 ] | ||||||||||||||||
|
Author: {'name': 'Daniel Moody', 'email': 'daniel.moody@mongodb.com', 'username': 'dmoody256'}Message: | ||||||||||||||||
| Comment by Daniel Moody [ 16/Sep/20 ] | ||||||||||||||||
|
Code Review: https://mongodbcr.appspot.com/674830001/ | ||||||||||||||||
| Comment by Kaloian Manassiev [ 09/Sep/20 ] | ||||||||||||||||
|
ryan.egesdahl, I have attached one such build.ninja, which reproduces this problem. | ||||||||||||||||
| Comment by Githook User [ 09/Sep/20 ] | ||||||||||||||||
|
Author: {'name': 'Kaloian Manassiev', 'email': 'kaloian.manassiev@mongodb.com', 'username': 'kaloianm'}Message: Revert " This reverts commit 58fd67fc2232a4ca591ff66443fd22213d4b5cac. | ||||||||||||||||
| Comment by Ryan Egesdahl (Inactive) [ 09/Sep/20 ] | ||||||||||||||||
|
kaloian.manassiev How strange. Do you still have the build.ninja from your error? If so, please post it so I can examine it. I get the feeling there is a complexity here that is specific to Windows. | ||||||||||||||||
| Comment by Kaloian Manassiev [ 09/Sep/20 ] | ||||||||||||||||
|
Reverting the commit from the previous comment and reopening this ticket, because after it, ninja builds no longer work on Windows (MSVC):
| ||||||||||||||||
| Comment by Githook User [ 09/Sep/20 ] | ||||||||||||||||
|
Author: {'name': 'Ryan Egesdahl', 'email': 'ryan.egesdahl@mongodb.com', 'username': 'deriamis'}Message: Allow Ninja to rebuild build.ninja any time a SCons tool or the compiler | ||||||||||||||||
| Comment by Githook User [ 04/Sep/20 ] | ||||||||||||||||
|
Author: {'name': 'Ryan Egesdahl', 'email': 'ryan.egesdahl@mongodb.com', 'username': 'deriamis'}Message: Revert " This reverts commit 4d43e298fe956c57b3cb0310bcd0785c19f75ef7. | ||||||||||||||||
| Comment by Githook User [ 03/Sep/20 ] | ||||||||||||||||
|
Author: {'name': 'Ryan Egesdahl', 'email': 'ryan.egesdahl@mongodb.com', 'username': 'deriamis'}Message: Allow Ninja to rebuild build.ninja any time a SCons tool or the compiler | ||||||||||||||||
| Comment by April Schoffer [ 03/Sep/20 ] | ||||||||||||||||
|
ryan.egesdahl to grab this and merge for daniel given it's approved. | ||||||||||||||||
| Comment by Daniel Moody [ 18/Aug/20 ] | ||||||||||||||||
|
possibly related to |