[SERVER-50385] Change unsupportedExpression to MONGO_UREACHABLE in SBE $text expression pre-visitor Created: 19/Aug/20  Updated: 29/Oct/23  Resolved: 02/Sep/20

Status: Closed
Project: Core Server
Component/s: Querying
Affects Version/s: None
Fix Version/s: 4.7.0

Type: Task Priority: Major - P3
Reporter: Anton Korshunov Assignee: David Storch
Resolution: Fixed Votes: 0
Labels: qexec-team
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Sprint: Query 2020-09-07
Participants:

 Description   

In WRITING-5356 we implemented support for legacy $text expression. The way it's implemented, we actually don’t use the match expression itself to evaluate the search predicate, but rather do it in a PlanStage layer, so this expression shouldn't ever appear as a filter in a PlanStage tree, meaning that we can never reach this line (and this is the reason we're not failing with an 'unsupported expression' error.

We need to change this line to MONGO_UREACHABLE along with a comment describing why we never need to translate this expression.

Same here.



 Comments   
Comment by Githook User [ 02/Sep/20 ]

Author:

{'name': 'David Storch', 'email': 'david.storch@mongodb.com', 'username': 'dstorch'}

Message: SERVER-50385 Use MONGO_UNREACHABLE in SBE visit() methods for $text MatchExpression nodes
Branch: master
https://github.com/mongodb/mongo/commit/f825465df95a1e663f65c149b2fe6412778372eb

Generated at Thu Feb 08 05:22:31 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.