[SERVER-50400] Migrating session info ignores ConfigurationInProgress instead of ConflictingOperationInProgress Created: 20/Aug/20 Updated: 29/Oct/23 Resolved: 25/Sep/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Sharding |
| Affects Version/s: | None |
| Fix Version/s: | 4.8.0 |
| Type: | Bug | Priority: | Minor - P4 |
| Reporter: | Max Hirschhorn | Assignee: | Sergi Mateo Bellido |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | neweng, sharding-wfbf-day | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Operating System: | ALL | ||||||||
| Participants: | |||||||||
| Description |
|
The changes from facdcf1 as part of There doesn't appear to be a way for TransactionParticipant::beginOrContinue(autocommit == boost::none) to throw a ConflictingOperationInProgress exception that I don't believe this issue is causing any chunk migrations to fail. Chunk migrations on the 4.2 branch appear to be similarly non-impacted. |
| Comments |
| Comment by Githook User [ 23/Sep/20 ] |
|
Author: {'name': 'Sergi Mateo Bellido', 'email': 'sergi.mateo-bellido@mongodb.com', 'username': 'smateo'}Message: |
| Comment by Kaloian Manassiev [ 23/Sep/20 ] |
|
sergi.mateo-bellido, in the master branch it is catching ErrorCodes::ConfigurationInProgress (which can never be thrown). The original exception was ErrorCodes::ConflictingOperationInProgress which got changed accidentally by that change. However, neither of these two errors can be thrown now, so we should just throw out this catch entry. |
| Comment by Kaloian Manassiev [ 16/Sep/20 ] |
|
Assigning to Sergi. Based on Max's observation that it us currently not possible for the TransactionParticipant::beginOrContinue call to throw this exception, I suggest that instead of fixing the catch condition, we throw out this catch clause. |