[SERVER-50403] Build server on combined visual studio image Created: 20/Aug/20  Updated: 29/Oct/23  Resolved: 21/Aug/20

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 4.2.10

Type: New Feature Priority: Major - P3
Reporter: Brian McCarthy Assignee: Daniel Moody
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Problem/Incident
Related
Backwards Compatibility: Fully Compatible
Sprint: Dev Platform 2020-08-24
Participants:
Linked BF Score: 0

 Comments   
Comment by Githook User [ 21/Aug/20 ]

Author:

{'name': 'Andrew Morrow', 'email': 'acm@mongodb.com', 'username': 'acmorrow'}

Message: SERVER-50403 SERVER-23208 Pick SCons upstream fix for SCons issue #3469

https://github.com/SCons/scons/commit/7c32091fccad5e70755dc46174fe516fff4549c3
(cherry picked from commit 18966553fc7f9d350c3428ea1a23162aba2526ef)
Branch: v4.2
https://github.com/mongodb/mongo/commit/b0b9ed24ad0511a1f8d91d6731ed36459daef2dd

Comment by Githook User [ 21/Aug/20 ]

Author:

{'name': 'Mathew Robinson', 'email': 'mathew.robinson@mongodb.com'}

Message: SERVER-50403 SERVER-45390 Bring Subst improvements downstream

(cherry picked from commit 01ccbf441e419c7c9edff997744b960e50491df4)
Branch: v4.2
https://github.com/mongodb/mongo/commit/7898e478d0b2e4d511ddb48960d7e85ab3a14d56

Comment by Githook User [ 21/Aug/20 ]

Author:

{'name': 'Mathew Robinson', 'email': 'mathew.robinson@mongodb.com'}

Message: SERVER-50403 SERVER-45336 Speed up Subst by preventing unnecessary Frame allocations

(cherry picked from commit c86d4ad8c63e27f733b29c5f6bdb394540975782)
Branch: v4.2
https://github.com/mongodb/mongo/commit/3c710e324007fdfee5645b17007e4542a796b235

Comment by Githook User [ 21/Aug/20 ]

Author:

{'name': 'Mathew Robinson', 'email': 'mathew.robinson@mongodb.com'}

Message: SERVER-50403 SERVER-45198 Upgrade SCons to 3.1.2

(cherry picked from commit e57b8036c94546a6494e81d46f552f1c23841eda)
Branch: v4.2
https://github.com/mongodb/mongo/commit/41b7a52ea47ddc4edd2c1dfbaec1fd73add98919

Comment by Githook User [ 21/Aug/20 ]

Author:

{'name': 'Mathew Robinson', 'email': 'mathew.robinson@mongodb.com'}

Message: SERVER-50403 SERVER-42264 Improve SCons performance

(cherry picked from commit 00e2bca5efcb74cb95b7d3824299a530a288a025)
Branch: v4.2
https://github.com/mongodb/mongo/commit/dc21f363524aeb47f270dd702b742a2b683a7400

Comment by Githook User [ 21/Aug/20 ]

Author:

{'name': 'Mathew Robinson', 'email': 'chasinglogic@gmail.com'}

Message: SERVER-50403 SERVER-25436: modify vendored scons to use win32 api CopyFile operation

(cherry picked from commit e73eb49ea2c6778699683db57aee221dbe339c4a)
Branch: v4.2
https://github.com/mongodb/mongo/commit/56e3a6637f68364058f6de2eb33aa1de190dd5a0

Comment by Githook User [ 21/Aug/20 ]

Author:

{'name': 'Mathew Robinson', 'email': 'mathew.robinson@mongodb.com'}

Message: SERVER-50403 SERVER-39467 Update EnsureSConsVersion to 3.1.1

(cherry picked from commit d362622b92319611dc247a94a6d125571c4b9b57)
Branch: v4.2
https://github.com/mongodb/mongo/commit/6fe58c3c890e5af151044ef86019a303ef2443ed

Comment by Githook User [ 21/Aug/20 ]

Author:

{'name': 'Mathew Robinson', 'email': 'chasinglogic@gmail.com'}

Message: SERVER-50403 SERVER-39467 Upgrade vendored SCons to 3.1.1

(cherry picked from commit 364b08d9d8348a9bf93cbff8eff7181da1a8f336)
Branch: v4.2
https://github.com/mongodb/mongo/commit/d02941c18774c64442f6ac18b8b2a51abc53ad50

Comment by Daniel Moody [ 21/Aug/20 ]

We amended the cherry-picks with this SERVER ticket as well as the original ticket, and put them in this branch to review the commit history: https://github.com/dmoody256/mongo/tree/SERVER-50403

Comment by Daniel Moody [ 21/Aug/20 ]

SCons did not support 2019 until scons 3.1.0, and was added initially in this PR: https://github.com/SCons/scons/pull/3408
Prior to that it had a bug where it would incorrectly ask vswhere for an invalid version and vswhere just returns the latest in that case 

We will need to back port a newer version of scons to the 4.2 branch to allow it to handle building with a system that has both 2017 and 2019 installed.

We will backport the SCons 3.1.2 version from the 4.4 branch along with custom updates in the local tree.

Generated at Thu Feb 08 05:22:34 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.