[SERVER-50423] Change memberConfig's slaveDelay field to secondaryDelaySecs in FCV 4.7 Created: 20/Aug/20  Updated: 29/Oct/23  Resolved: 29/Jan/21

Status: Closed
Project: Core Server
Component/s: Replication
Affects Version/s: None
Fix Version/s: 4.9.0

Type: Improvement Priority: Major - P3
Reporter: Pavithra Vetriselvan Assignee: Ali Mir
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on SERVER-51110 Associate feature flags with release ... Closed
is depended on by SERVER-52349 Enable feature flag for Remove the Ne... Closed
Documented
is documented by DOCS-14169 Investigate changes in SERVER-50423: ... Closed
Related
related to SERVER-53894 setFCV transitions to fully upgraded/... Closed
related to SERVER-53953 Fix invariant failure when downgradin... Closed
related to SERVER-54389 Audit internal uses of force reconfig... Closed
Backwards Compatibility: Fully Compatible
Sprint: Repl 2020-09-21, Repl 2020-11-02, Repl 2020-11-16, Repl 2020-11-30, Repl 2020-12-14, Repl 2020-12-28, Repl 2021-01-11, Repl 2021-01-25, Repl 2021-02-08
Participants:

 Comments   
Comment by Githook User [ 29/Jan/21 ]

Author:

{'name': 'Ali Mir', 'email': 'ali.mir@mongodb.com', 'username': 'ali-mir'}

Message: SERVER-50423 Rename jstests with slave references
Branch: master
https://github.com/mongodb/mongo/commit/e0755098879d67a8a32cf4519d4f8f57929a0046

Comment by Githook User [ 28/Jan/21 ]

Author:

{'name': 'Ali Mir', 'email': 'ali.mir@mongodb.com', 'username': 'ali-mir'}

Message: SERVER-50423 Add featureFlagUseSecondaryDelaySecs to disabled feature flags variants (#804)
Branch: master
https://github.com/10gen/dsi/commit/969990ec4ced08c675990052c0524eedd87bdc7d

Comment by Githook User [ 28/Jan/21 ]

Author:

{'name': 'Ali Mir', 'email': 'ali.mir@mongodb.com', 'username': 'ali-mir'}

Message: SERVER-50423 Change memberConfig's slaveDelay field to secondaryDelaySecs
Branch: master
https://github.com/mongodb/mongo/commit/35a6a97338930d75a7f5cfd89671ae9af65aaf85

Comment by Githook User [ 28/Jan/21 ]

Author:

{'name': 'Ali Mir', 'email': 'ali.mir@mongodb.com', 'username': 'ali-mir'}

Message: SERVER-50423 Change memberConfig's slaveDelay field to secondaryDelaySecs
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/648edcd0be0b06c60de8a35f4d475a65bfa0896a

Comment by Ali Mir [ 21/Jan/21 ]

While debugging a test failure for this patch, we uncovered a bug in the setFCV code path. jason.chan documented it in SERVER-53894. We found that in certain cases, the local FCV document can be updated to the fully upgraded version before all the upgrade/downgrade behavior is complete. In this patch, this behavior is the reconfig issued to use the secondaryDelaySecs or slaveDelay field. We noticed that the bug caused the test set_feature_compatibility_version.js to hang. When we put together a quick fix for the issue, the test was passing. I put up a patch with the quick fix here (The index_downgrade_fcv.js failure is unrelated) and the results are mostly green. As a result, this ticket can't be committed until SERVER-53894 is fixed. I'm going to continue investigating exactly why this patch uncovered this bug and write a comment accordingly, but I just wanted to update others.

cc pavithra.vetriselvan siyuan.zhou

Comment by Githook User [ 20/Jan/21 ]

Author:

{'name': 'Ali Mir', 'email': 'ali.mir@mongodb.com', 'username': 'ali-mir'}

Message: SERVER-50423 Set FCV before writing initial replica set config
Branch: master
https://github.com/mongodb/mongo/commit/90e4270e9b22071c7d0367195c56bf2c5b50e56f

Comment by Steven Vannelli [ 02/Oct/20 ]

Removing this from the current sprint since it is dependent on CLOUDP-70821.

Comment by Tess Avitabile (Inactive) [ 03/Sep/20 ]

Please make sure that if this goes in over multiple commits, that it is flag-guarded in case there's a continuous release in the interim. You should also be sure to use the current FCV values. After the 4.7 release on 9/8, we'll make FCV 4.8 constants available for use, and you should use those. If this ticket gets pushed after the 4.8 release around 9/21, you should use FCV 4.9.

Generated at Thu Feb 08 05:22:37 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.