[SERVER-50467] Ensure that tenant migration donor only removes a ReplicaSetMonitor for a recipient when the last migration to that recipient completes Created: 21/Aug/20 Updated: 29/Oct/23 Resolved: 08/Dec/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Sharding |
| Affects Version/s: | None |
| Fix Version/s: | 4.9.0-alpha0 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Cheahuychou Mao | Assignee: | Andrew Shuvalov (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | pm-1791_milestone-D | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||||||||||||||
| Sprint: | Sharding 2020-10-19, Sharding 2020-11-02, Sharding 2020-11-16, Sharding 2020-11-30, Sharding 2020-12-14 | ||||||||||||||||||||||||||||||||
| Participants: | |||||||||||||||||||||||||||||||||
| Linked BF Score: | 17 | ||||||||||||||||||||||||||||||||
| Description |
|
See that ticket's description for background. We handled destroying the donor's ReplicaSetMonitor for the recipient once the donor completed the migration by calling ReplicaSetMonitor::remove in the RemoteCommandTargeterRS destructor. However, if the donor was migrating two tenants to the same recipient concurrently, the two migrations would be sharing the same ReplicaSetMonitor, and the first migration to finish would rip the ReplicaSetMonitor out from under the second migration. This ticket is to ensure the ReplicaSetMonitor is only removed when the ReplicasSetMonitor does not have any more users. There is already a commented-out test case for this here. |
| Comments |
| Comment by Githook User [ 08/Dec/20 ] |
|
Author: {'name': 'Andrew Shuvalov', 'email': 'andrew.shuvalov@mongodb.com', 'username': 'shuvalov-mdb'}Message: |
| Comment by Githook User [ 08/Dec/20 ] |
|
Author: {'name': 'Andrew Shuvalov', 'email': 'andrew.shuvalov@mongodb.com', 'username': 'shuvalov-mdb'}Message: |
| Comment by Githook User [ 24/Nov/20 ] |
|
Author: {'name': 'Andrew Shuvalov', 'email': 'andrew.shuvalov@mongodb.com', 'username': 'shuvalov-mdb'}Message: |