[SERVER-50470] Make persistParticipantsList convert TransactionCoordinatorReachedAbortDecision to NoSuchTransaction Created: 21/Aug/20  Updated: 29/Oct/23  Resolved: 15/Oct/20

Status: Closed
Project: Core Server
Component/s: Sharding
Affects Version/s: None
Fix Version/s: 4.9.0, 4.4.2

Type: Task Priority: Major - P3
Reporter: Haley Connelly Assignee: Andrew Shuvalov (Inactive)
Resolution: Fixed Votes: 0
Labels: neweng
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
Problem/Incident
Backwards Compatibility: Fully Compatible
Backport Requested:
v4.4
Sprint: Sharding 2020-10-05, Sharding 2020-10-19
Participants:
Linked BF Score: 40

 Description   

Currently,  persistParticipantsList never converts the exception thrown, "ErrorCodes::TransactionCoordinatorReachedAbortDecision", when the two phase commit deadline exceeds the time limit, causing the invariant to be hit.

Instead, if the transaction times out while the persisting the participants, persistParticipantsList should convert the exception to be NoSuchTransaction - similar to what sendPrepareToShard does.



 Comments   
Comment by Githook User [ 15/Oct/20 ]

Author:

{'name': 'Andrew Shuvalov', 'email': 'andrew.shuvalov@mongodb.com', 'username': 'shuvalov-mdb'}

Message: SERVER-50470: exclude test txn_two_phase_commit_timeout.js from multiversion as not compatible with version 4.2
Branch: v4.4
https://github.com/mongodb/mongo/commit/add3ec1b1684d8d935dbad33339239ba691a1889

Comment by Andrew Shuvalov (Inactive) [ 15/Oct/20 ]

Reopen to submit the change to disable the test version permutation 

Comment by Githook User [ 12/Oct/20 ]

Author:

{'name': 'Andrew Shuvalov', 'email': 'andrew.shuvalov@mongodb.com', 'username': 'shuvalov-mdb'}

Message: SERVER-50470: Convert TransactionCoordinatorReachedAbortDecision to NoSuchTransaction before propagating

(cherry picked from commit 11d461d8335e5b63d2bd2d5509dd32b0775f1700)
Branch: v4.4
https://github.com/mongodb/mongo/commit/c718d3ef316865a8b14852f1b20db66331aaa4ca

Comment by Andrew Shuvalov (Inactive) [ 09/Oct/20 ]

Prevented me from closing while backport is open. Will finish it soon...

Comment by Githook User [ 09/Oct/20 ]

Author:

{'name': 'Andrew Shuvalov', 'email': 'andrew.shuvalov@mongodb.com', 'username': 'shuvalov-mdb'}

Message: SERVER-50470: Convert TransactionCoordinatorReachedAbortDecision to NoSuchTransaction before propagating
Branch: master
https://github.com/mongodb/mongo/commit/11d461d8335e5b63d2bd2d5509dd32b0775f1700

Comment by Andrew Shuvalov (Inactive) [ 07/Oct/20 ]

Tickets filed as follow up: https://jira.mongodb.org/browse/SERVER-51417 and https://jira.mongodb.org/browse/SERVER-51325 

Generated at Thu Feb 08 05:22:44 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.