[SERVER-50516] Rename variables in sdam_datatypes.h Created: 25/Aug/20  Updated: 29/Oct/23  Resolved: 21/Oct/20

Status: Closed
Project: Core Server
Component/s: Replication
Affects Version/s: None
Fix Version/s: 4.9.0

Type: Task Priority: Major - P3
Reporter: Pavithra Vetriselvan Assignee: Billy Donahue
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to SERVER-51814 remove dangerous streaming operators ... Closed
Backwards Compatibility: Fully Compatible
Sprint: Service arch 2020-11-02
Participants:

 Description   

Since we've changed CmdIsMaster to CmdHello in both replication_info and cluster_is_master_cmd (the latter file name is going to change), we should consider renaming classes like IsMasterOutcome to HelloOutcome.

This will help with maintaining consistency across various server classes that use metadata from the hello command. We will be doing something similar with IsMasterResponse (HelloResponse) and IsMasterMetrics (HelloMetrics).

We can also change IsMasterRTT to HelloRTT or even handshakeRTT.



 Comments   
Comment by Githook User [ 21/Oct/20 ]

Author:

{'name': 'Billy Donahue', 'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue'}

Message: SERVER-50516 renames: IsMasterRTT=>HelloRTT, IsMasterOutcome=>HelloOutcome
Branch: master
https://github.com/mongodb/mongo/commit/a11b6b7bdd429768c2948d9cae4911aa7b87afee

Comment by Billy Donahue [ 20/Oct/20 ]

CR http://mongodbcr.appspot.com/706390002

Generated at Thu Feb 08 05:22:51 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.