[SERVER-50516] Rename variables in sdam_datatypes.h Created: 25/Aug/20 Updated: 29/Oct/23 Resolved: 21/Oct/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Replication |
| Affects Version/s: | None |
| Fix Version/s: | 4.9.0 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Pavithra Vetriselvan | Assignee: | Billy Donahue |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Sprint: | Service arch 2020-11-02 | ||||||||
| Participants: | |||||||||
| Description |
|
Since we've changed CmdIsMaster to CmdHello in both replication_info and cluster_is_master_cmd (the latter file name is going to change), we should consider renaming classes like IsMasterOutcome to HelloOutcome. This will help with maintaining consistency across various server classes that use metadata from the hello command. We will be doing something similar with IsMasterResponse (HelloResponse) and IsMasterMetrics (HelloMetrics). We can also change IsMasterRTT to HelloRTT or even handshakeRTT. |
| Comments |
| Comment by Githook User [ 21/Oct/20 ] |
|
Author: {'name': 'Billy Donahue', 'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue'}Message: |
| Comment by Billy Donahue [ 20/Oct/20 ] |