[SERVER-50674] Darwin --separate-debug tool should not strip with the `x` flag Created: 01/Sep/20  Updated: 29/Oct/23  Resolved: 02/Sep/20

Status: Closed
Project: Core Server
Component/s: Build
Affects Version/s: None
Fix Version/s: 4.7.0, 4.4.2

Type: Bug Priority: Major - P3
Reporter: Andrew Morrow (Inactive) Assignee: Andrew Morrow (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Requested:
v4.4
Sprint: Dev Platform 2020-09-07
Participants:

 Description   

When support for --separate-debug was added (https://github.com/mongodb/mongo/commit/6d475fdb5a76acab760ce4b6709b60a4c8c9aec6) as part of mobile development, we intended to strip local symbols, where doing so was appropriate and perhaps important for size reasons.

Later, we started using --separate-debug for all builds, whether or not stripping local symbols was appropriate.

As a result, macOS builds are having local symbol information stripped, which may result in inferior debugging or backtracing. We should remove the -x flag from the $STRIP invocation on Darwin in separate_debug.py.



 Comments   
Comment by Githook User [ 09/Sep/20 ]

Author:

{'name': 'Andrew Morrow', 'email': 'acm@mongodb.com', 'username': 'acmorrow'}

Message: SERVER-50674 Don't strip local symbols on darwin

(cherry picked from commit 9339181a83b03684a92de1ca33b4a1587888d4e1)
Branch: v4.4
https://github.com/mongodb/mongo/commit/5c4ea55389b690cbc569ea800cb57c2640876107

Comment by Githook User [ 02/Sep/20 ]

Author:

{'name': 'Andrew Morrow', 'email': 'acm@mongodb.com', 'username': 'acmorrow'}

Message: SERVER-50674 Don't strip local symbols on darwin
Branch: master
https://github.com/mongodb/mongo/commit/9339181a83b03684a92de1ca33b4a1587888d4e1

Generated at Thu Feb 08 05:23:16 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.