[SERVER-50684] Rename internalAssert -> iassert, trim minor implementation details Created: 01/Sep/20 Updated: 29/Oct/23 Resolved: 20/Nov/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 4.9.0 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Spencer Brody (Inactive) | Assignee: | Billy Donahue |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | servicearch-wfbf-day | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Sprint: | Service arch 2020-11-30 |
| Participants: |
| Description |
|
Either by renaming internalAssert to iassert, or by renaming uassert to userAssert and fassert to fatalAssert. |
| Comments |
| Comment by Githook User [ 20/Nov/20 ] |
|
Author: {'name': 'Billy Donahue', 'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue'}Message: |
| Comment by Billy Donahue [ 19/Nov/20 ] |
|
Trimming some fat in the implementation as well. Not affecting API. Just compressing the overloads and avoiding a string copy. |
| Comment by Billy Donahue [ 19/Nov/20 ] |
| Comment by Connie Chen [ 15/Sep/20 ] |
|
Service arch team has decided to rename internalAssert to iassert (from WFBF triage). |
| Comment by Benjamin Caimano (Inactive) [ 01/Sep/20 ] |
|
I think my general argument is that I think we should allow both long and short for now. People are obviously divided but these are free functions (macros), so we're not incurring much maintenance. It doesn't hurt anybody and people already type uassertStatusOK() everywhere. I wouldn't mind if we allowed userAssert(Status) while we're at it. invariant(status) is already a thing. |
| Comment by Spencer Brody (Inactive) [ 01/Sep/20 ] |
|
Personally I'd vote for renaming internalAssert to iassert. Generally speaking I prefer longer, more explicit names over shorter ones, but in this specific case since these calls are so prevalent throughout our codebase I think the value of conciseness is higher than normal. |