[SERVER-50686] Rename PrimaryOnlyService::Instance::onCompletion() to getCompletionFuture() Created: 01/Sep/20  Updated: 29/Oct/23  Resolved: 02/Sep/20

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 4.7.0

Type: Task Priority: Major - P3
Reporter: Spencer Brody (Inactive) Assignee: Spencer Brody (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Sprint: Service arch 2020-09-07
Participants:

 Description   

It's a little confusing right now since Futures provide an onCompletion() method of their own to add completion callbacks, so you can wind up with instance->onCompletion().onCompletion([]{ /*[...]*/ });

 

This also lets me sidestep a name collision with the existing TransactionCoordinator::onCompletion() method.



 Comments   
Comment by Githook User [ 02/Sep/20 ]

Author:

{'name': 'Spencer T Brody', 'email': 'spencer@mongodb.com', 'username': 'stbrody'}

Message: SERVER-50686 Rename PrimaryOnlyService::Instance::onCompletion() to getCompletionFuture()
Branch: master
https://github.com/mongodb/mongo/commit/5f9a904ae5b8d1554516da08e73f1d8b1a1fc8fd

Generated at Thu Feb 08 05:23:18 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.