[SERVER-50753] Support $indexOfBytes and $indexOfCP in SBE Created: 03/Sep/20  Updated: 29/Oct/23  Resolved: 08/Oct/20

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 4.8 Required

Type: Task Priority: Major - P3
Reporter: David Storch Assignee: Claire Childs (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Problem/Incident
causes SERVER-51485 dependency on absl internals in getCo... Closed
Backwards Compatibility: Fully Compatible
Sprint: Query 2020-09-21, Query 2020-10-05, Query 2020-10-19
Participants:

 Comments   
Comment by Billy Donahue [ 12/Oct/20 ]

There's already a CR attached to https://jira.mongodb.org/browse/SERVER-51485
I assigned it to R=claire.childs, but anyone who wants it, I guess.

Comment by Billy Donahue [ 10/Oct/20 ]

Was there a code review for that commit?

Anyway, we need to avoid reaching into absl's internals as this commit did.

https://github.com/mongodb/mongo/commit/bf9418e7fa43768545dc828d6c5f3326935a3d9e#diff-33800e2e4dcd1c7a589bd18dbb04c5b1

It looks like all we need is a count leading zeros function. We can use mongo/platform/bits.h which has the same function.

Comment by Githook User [ 08/Oct/20 ]

Author:

{'name': 'Claire Childs', 'email': 'claire.childs@mongodb.com', 'username': 'c-childs'}

Message: SERVER-50753 support $indexOfBytes and $indexOfCP in SBE
Branch: master
https://github.com/mongodb/mongo/commit/bf9418e7fa43768545dc828d6c5f3326935a3d9e

Generated at Thu Feb 08 05:23:29 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.