[SERVER-50812] Remove the SetShardVersion command Created: 09/Sep/20  Updated: 29/Oct/23  Resolved: 14/Jun/22

Status: Closed
Project: Core Server
Component/s: Sharding
Affects Version/s: None
Fix Version/s: 6.1.0-rc0

Type: Task Priority: Major - P3
Reporter: Tommaso Tocci Assignee: Kaloian Manassiev
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on SERVER-46199 Implement collection cache on top of ... Closed
depends on SERVER-61072 Remove MigrationRecipientCriticalSect... Closed
Related
related to SERVER-47956 Get rid of the "authoritative" and "n... Closed
Backwards Compatibility: Fully Compatible
Sprint: Sharding EMEA 2021-11-01, Sharding EMEA 2021-11-15, Sharding EMEA 2021-11-29, Sharding EMEA 2021-12-13, Sharding EMEA 2021-12-27, Sharding EMEA 2022-01-10, Sharding EMEA 2022-01-24, Sharding EMEA 2022-02-07, Sharding EMEA 2022-02-21, Sharding EMEA 2022-03-07, Sharding EMEA 2022-03-21, Sharding EMEA 2022-04-04, Sharding EMEA 2022-04-18, Sharding EMEA 2022-06-27
Participants:

 Description   

the usage of forceRefresh parameter has been removed in SERVER-46199 but there the parameter is still accepted by the SetShardVersion command. This ticket is to remove all the leftover traces of this parameter.

Moreover this if-else block should be removed and instead just call onShardVersionMismatch.



 Comments   
Comment by Githook User [ 14/Jun/22 ]

Author:

{'name': 'Kaloian Manassiev', 'email': 'kaloian.manassiev@mongodb.com', 'username': 'kaloianm'}

Message: SERVER-50812 Remove the `setShardVersion` command
Branch: master
https://github.com/mongodb/mongo/commit/4d41330a4a68417448ad5cc7e4abf632f5e5a170

Comment by Sergi Mateo Bellido [ 11/Apr/22 ]

I had this task seating in my backlog for a while. Right now, the setShardVersion command is only used in the old migration protocol as part of the best-effort refresh attempt on the recipient. This old migration protocol is going to be removed in 6.1 (SERVER-61072) once it becomes FCV dead code. I will propose to add this task to the 6.0 cleanup project (PM-2460) too and mark it as dependent of the removal of the old migration protocol.

Comment by Kaloian Manassiev [ 21/Oct/21 ]

Passing on to Sergi to evaluate the feasibility of throwing out setShardVersion.

Comment by Kaloian Manassiev [ 12/Oct/21 ]

As part of this change we should also take the opportunity to either remove setShardVersion entirely and rely on other commands for advancing the shard version of a shard.

Generated at Thu Feb 08 05:23:39 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.