[SERVER-50867] Roll back ServiceStateMachine changes temporarily Created: 10/Sep/20  Updated: 29/Oct/23  Resolved: 10/Dec/20

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 4.8.0, 4.9.0

Type: Task Priority: Major - P3
Reporter: Benjamin Caimano (Inactive) Assignee: Benjamin Caimano (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Problem/Incident
Related
related to SERVER-60647 Increase of user assertions in 5.0.x Backlog
related to SERVER-50682 Coverity analysis defect 116228: Pars... Closed
related to SERVER-49072 Make ServiceExecutors into Decorations Closed
related to SERVER-49104 Futurize ServiceStateMachine transitions Closed
related to SERVER-48980 Associate ServiceExecutors with Clients Closed
Backwards Compatibility: Fully Compatible
Sprint: Service arch 2020-09-21
Participants:
Linked BF Score: 50

 Description   

We've managed to introduce some perf regressions while working on the ServiceStateMachine. We should roll back the changes on master and continue work on a feature branch fixed-thread-pool-handshaking.



 Comments   
Comment by Benjamin Caimano (Inactive) [ 10/Dec/20 ]

This was reverted for v4.9.0.

Comment by Githook User [ 03/Dec/20 ]

Author:

{'name': 'Ben Caimano', 'email': 'ben.caimano@10gen.com'}

Message: Revert "SERVER-50867 Roll back ServiceStateMachine changes temporarily"

This reverts commit 575f370475bd31fc457a93a776061f1b80448028.
Branch: master
https://github.com/mongodb/mongo/commit/22c85e1413b6b649ec34cd68f063bbe3a22fdbf6

Comment by Githook User [ 14/Sep/20 ]

Author:

{'name': 'Ben Caimano', 'email': 'ben.caimano@10gen.com'}

Message: SERVER-50867 Roll back ServiceStateMachine changes temporarily

This reverts commit 96e5ab8c9e0b20e58b81e5e8bf60d2a582c58d62.
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/3f5816a914d84c41d6aac63de63d5bfc623b3cf2

Comment by Githook User [ 14/Sep/20 ]

Author:

{'name': 'Ben Caimano', 'email': 'ben.caimano@10gen.com'}

Message: Revert "SERVER-50867 Roll back ServiceStateMachine changes temporarily"

This reverts commit f1aa406b208333cee000b59151a9e90b6c21bcfd.
Branch: fixed_thread_pool_handshaking
https://github.com/10gen/mongo-enterprise-modules/commit/377efa8e4f44ed1db2b9322e313cb3250c3b6008

Comment by Githook User [ 14/Sep/20 ]

Author:

{'name': 'Ben Caimano', 'email': 'ben.caimano@10gen.com'}

Message: SERVER-50867 Roll back ServiceStateMachine changes temporarily

This reverts commit 96e5ab8c9e0b20e58b81e5e8bf60d2a582c58d62.
Branch: fixed_thread_pool_handshaking
https://github.com/10gen/mongo-enterprise-modules/commit/f1aa406b208333cee000b59151a9e90b6c21bcfd

Comment by Githook User [ 14/Sep/20 ]

Author:

{'name': 'Ben Caimano', 'email': 'ben.caimano@10gen.com'}

Message: SERVER-50867 Roll back ServiceStateMachine changes temporarily

This reverts these commits:
b039b24746e1d1fb10a32e1ca4831423c01d4cd7: SERVER-48980
97e16187ff3065d242a61a52e7b6edd4d439fb30: SERVER-49072
0607a6c291bf4cf4580a4444d826ed3c3ac3df47: SERVER-49104
Branch: master
https://github.com/mongodb/mongo/commit/827a25eb01bc5ddf766b3a543ef0ba5112953e1b

Comment by Githook User [ 14/Sep/20 ]

Author:

{'name': 'Ben Caimano', 'email': 'ben.caimano@10gen.com'}

Message: Revert "SERVER-50867 Roll back ServiceStateMachine changes temporarily"

This reverts commit 575f370475bd31fc457a93a776061f1b80448028.
Branch: fixed_thread_pool_handshaking
https://github.com/mongodb/mongo/commit/46b220b83efc24d85ff90fc1727d5a22ffcb2960

Comment by Githook User [ 14/Sep/20 ]

Author:

{'name': 'Ben Caimano', 'email': 'ben.caimano@10gen.com'}

Message: SERVER-50867 Roll back ServiceStateMachine changes temporarily

This reverts these commits:
b039b24746e1d1fb10a32e1ca4831423c01d4cd7: SERVER-48980
97e16187ff3065d242a61a52e7b6edd4d439fb30: SERVER-49072
0607a6c291bf4cf4580a4444d826ed3c3ac3df47: SERVER-49104
Branch: fixed_thread_pool_handshaking
https://github.com/mongodb/mongo/commit/575f370475bd31fc457a93a776061f1b80448028

Generated at Thu Feb 08 05:23:48 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.