[SERVER-51050] Selected Tests should not generate enterprise tests on non-enterprise builds Created: 18/Sep/20  Updated: 29/Oct/23  Resolved: 23/Oct/20

Status: Closed
Project: Core Server
Component/s: Testing Infrastructure
Affects Version/s: None
Fix Version/s: 4.9.0

Type: Bug Priority: Major - P3
Reporter: David Bradford (Inactive) Assignee: Lydia Stepanek (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: DAG 2020-10-19, DAG 2020-11-02
Participants:
Story Points: 3

 Description   

It looks like selected tests is trying to run enterprise tests on non-enterprise build variants. This won't work (the test doesn't exist) and causes the task to fail. We should not do that.


As a server engineer,
I do no want to run enterprise tests in non-enterprise builds
so that my tasks don't fail.


AC:

  • selected_tests on non-enterprise build-variants does not generate enterprise tests.


 Comments   
Comment by Githook User [ 23/Oct/20 ]

Author:

{'name': 'Lydia Stepanek', 'email': 'lydia.stepanek@mongodb.com', 'username': 'lydiastepanek'}

Message: SERVER-51050 Selected Tests should not generate enterprise tests on non-enterprise builds
Branch: master
https://github.com/mongodb/mongo/commit/8fb7a62652c5fe54da47eab77e28111f00b99d7f

Comment by Lydia Stepanek (Inactive) [ 23/Oct/20 ]

The issue is that enterprise tests are turning up in yml suite files, and thus, when a task like noPassthrough is run, and it depends on a suite file like no_passthrough_4.yml (which contains src/mongo/db/modules/enterprise/jstests/hot_backups/backup_restore_size_storer.js as a test), it runs backup_restore_size_storer.js as part of the noPassthrough task. This is fine when noPassthrough runs on variants that have enterprise modules installed, like enterprise-rhel-62-64-bit-dynamic-required, but fails when it runs on variants that don't, like linux-64-debug.

The cause of this issue is that selected_tests_gen is generating one group of suite files (no_passthrough_0.yml, no_passthrough_1.yml, no_passthrough_2.yml, no_passthrough_3.yml, no_passthrough_4.yml, no_passthrough_misc.yml) per task, and then all of the variants are sharing the same suite files. The solution is to separate suite files by variant, resulting in the following no_passthrough suites on enterprise-rhel-62-64-bit-dynamic-required and linux-64-debug:

  • no_passthrough_enterprise-rhel-62-64-bit-dynamic-required_0.yml
  • no_passthrough_enterprise-rhel-62-64-bit-dynamic-required_1.yml
  • no_passthrough_enterprise-rhel-62-64-bit-dynamic-required_2.yml
  • no_passthrough_enterprise-rhel-62-64-bit-dynamic-required_3.yml
  • no_passthrough_enterprise-rhel-62-64-bit-dynamic-required_4.yml
  • no_passthrough_enterprise-rhel-62-64-bit-dynamic-required_misc.yml
  • no_passthrough_linux-64-debug_0.yml
  • no_passthrough_linux-64-debug_1.yml
  • no_passthrough_linux-64-debug_2.yml
  • no_passthrough_linux-64-debug_3.yml
  • no_passthrough_linux-64-debug_4.yml
  • no_passthrough_linux-64-debug_misc.yml

With this fix, variants only use the suite files relevant to them.

Comment by Lydia Stepanek (Inactive) [ 22/Oct/20 ]

https://mongodbcr.appspot.com/713940001/

Generated at Thu Feb 08 05:24:22 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.