[SERVER-51069] Typo in read_write_concern_defaults_application.js Created: 20/Sep/20 Updated: 29/Oct/23 Resolved: 16/Nov/22 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Sharding |
| Affects Version/s: | None |
| Fix Version/s: | 6.3.0-rc0 |
| Type: | Bug | Priority: | Trivial - P5 |
| Reporter: | A. Jesse Jiryu Davis | Assignee: | Marcos José Grillo Ramirez |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | neweng, sharding-common-backlog, sharding-wfbf-day | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Operating System: | ALL | ||||||||
| Sprint: | Sharding EMEA 2022-11-28 | ||||||||
| Participants: | |||||||||
| Description |
|
While reading read_write_concern_defaults_application.js, I happened to notice that it creates roles "foo" and "bar", grants role "bar" to role "foo", and then tests revokeRolesFromRole by revoking the "foo" role from itself! In other words, the "foo" role is revoked from the "foo" role. The test was probably intended to revoke "bar" role from the "foo" role. The test still fulfills its purpose but it doesn't test revokeRolesFromRole as it's used in the wild. |
| Comments |
| Comment by Githook User [ 16/Nov/22 ] |
|
Author: {'name': 'Marcos José Grillo Ramirez', 'email': 'marcos.grillo@mongodb.com', 'username': 'm4nti5'}Message: |
| Comment by Marcos José Grillo Ramirez [ 15/Nov/22 ] |
|
Code review: |