[SERVER-51078] waitWhileFailPointEnabled() interruptibility should be reevaluated Created: 21/Sep/20 Updated: 29/Oct/23 Resolved: 01/Feb/21 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 4.9.0 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Benjamin Caimano (Inactive) | Assignee: | Gabriel Russell (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | servicearch-wfbf-day | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||
| Operating System: | ALL | ||||||||||||
| Sprint: | Service arch 2020-12-28, Service Arch 2021-02-08 | ||||||||||||
| Participants: | |||||||||||||
| Linked BF Score: | 12 | ||||||||||||
| Description |
|
CurOpFailpointHelpers::waitWhileFailPointEnabled() here takes a checkForInterrupt argument that is set to false by default. It is set to true in a small handful of cases. It also has the ability take a "shouldCheckForInterrupt" data field (see here) that can be set on a test by test basis. I believe that CurOpFailpointHelpers::waitWhileFailPointEnabled() should not have this argument and should instead have a consistent default that can be overridden by the "shouldCheckForInterrupt" field. I could see arguments either way for it defaulting to "true" or "false". Either way, some tests will now need to set "shouldCheckForInterrupt", probably based on whether they include intentional interruptions (like sharding/killop.js). |
| Comments |
| Comment by Githook User [ 29/Jan/21 ] |
|
Author: {'name': 'Gabriel Russell', 'email': 'gabriel.russell@mongodb.com', 'username': 'gabrielrussell'}Message: |