[SERVER-51106] Make the isMaster command a derived class of hello Created: 23/Sep/20  Updated: 29/Oct/23  Resolved: 23/Sep/20

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 4.8.0, 4.4.2, 4.2.11, 4.0.21, 3.6.21

Type: Task Priority: Major - P3
Reporter: Ali Mir Assignee: Ali Mir
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Backwards Compatibility: Fully Compatible
Backport Requested:
v4.4, v4.2, v4.0, v3.6
Sprint: Repl 2020-10-05
Participants:

 Description   

Upon investigation of SERVER-50419, we've discovered that the current implementation does not allow us track commands.hello and commands.isMaster as separate metrics. As a result, instead of aliasing hello to isMaster, we should split the two into separate commands and make isMaster a derived class of hello to allow the commands to share functionality.

In this ticket, we should revert the C++ changes from SERVER-50640. With hello and isMaster being separate commands, the original implementation of listCommands will return both isMaster and hello.



 Comments   
Comment by Githook User [ 05/Oct/20 ]

Author:

{'name': 'Ali Mir', 'email': 'ali.mir@mongodb.com', 'username': 'ali-mir'}

Message: SERVER-51106 Make the isMaster command a derived class of hello

(cherry picked from commit e178007c01565bf59d038f3be1566da036c60397)
Branch: v3.6
https://github.com/mongodb/mongo/commit/8ec2a851c8fb250ad69f020313633b0cf68346e4

Comment by Githook User [ 05/Oct/20 ]

Author:

{'name': 'Ali Mir', 'email': 'ali.mir@mongodb.com', 'username': 'ali-mir'}

Message: SERVER-51106 Make the isMaster command a derived class of hello

(cherry picked from commit e178007c01565bf59d038f3be1566da036c60397)
Branch: v4.2
https://github.com/mongodb/mongo/commit/b1e8378b3a37b4b98d675309fbb43e5e405a782e

Comment by Githook User [ 05/Oct/20 ]

Author:

{'name': 'Ali Mir', 'email': 'ali.mir@mongodb.com', 'username': 'ali-mir'}

Message: SERVER-51106 Make the isMaster command a derived class of hello

(cherry picked from commit e178007c01565bf59d038f3be1566da036c60397)
Branch: v4.0
https://github.com/mongodb/mongo/commit/02ea85d348d4f03459fc2661f76992fff4ce48a7

Comment by Githook User [ 05/Oct/20 ]

Author:

{'name': 'Ali Mir', 'email': 'ali.mir@mongodb.com', 'username': 'ali-mir'}

Message: SERVER-51106 Make the isMaster command a derived class of hello

(cherry picked from commit e178007c01565bf59d038f3be1566da036c60397)
Branch: v4.4
https://github.com/mongodb/mongo/commit/5ad3e5c6ade3ac13880ce44f94e5aff999e9ead5

Comment by Githook User [ 23/Sep/20 ]

Author:

{'name': 'Ali Mir', 'email': 'ali.mir@mongodb.com', 'username': 'ali-mir'}

Message: SERVER-51106 Make the isMaster command a derived class of hello
Branch: master
https://github.com/mongodb/mongo/commit/e178007c01565bf59d038f3be1566da036c60397

Generated at Thu Feb 08 05:24:31 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.