[SERVER-51106] Make the isMaster command a derived class of hello Created: 23/Sep/20 Updated: 29/Oct/23 Resolved: 23/Sep/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 4.8.0, 4.4.2, 4.2.11, 4.0.21, 3.6.21 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Ali Mir | Assignee: | Ali Mir |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||
| Backwards Compatibility: | Fully Compatible | ||||
| Backport Requested: |
v4.4, v4.2, v4.0, v3.6
|
||||
| Sprint: | Repl 2020-10-05 | ||||
| Participants: | |||||
| Description |
|
Upon investigation of SERVER-50419, we've discovered that the current implementation does not allow us track commands.hello and commands.isMaster as separate metrics. As a result, instead of aliasing hello to isMaster, we should split the two into separate commands and make isMaster a derived class of hello to allow the commands to share functionality. In this ticket, we should revert the C++ changes from |
| Comments |
| Comment by Githook User [ 05/Oct/20 ] |
|
Author: {'name': 'Ali Mir', 'email': 'ali.mir@mongodb.com', 'username': 'ali-mir'}Message: (cherry picked from commit e178007c01565bf59d038f3be1566da036c60397) |
| Comment by Githook User [ 05/Oct/20 ] |
|
Author: {'name': 'Ali Mir', 'email': 'ali.mir@mongodb.com', 'username': 'ali-mir'}Message: (cherry picked from commit e178007c01565bf59d038f3be1566da036c60397) |
| Comment by Githook User [ 05/Oct/20 ] |
|
Author: {'name': 'Ali Mir', 'email': 'ali.mir@mongodb.com', 'username': 'ali-mir'}Message: (cherry picked from commit e178007c01565bf59d038f3be1566da036c60397) |
| Comment by Githook User [ 05/Oct/20 ] |
|
Author: {'name': 'Ali Mir', 'email': 'ali.mir@mongodb.com', 'username': 'ali-mir'}Message: (cherry picked from commit e178007c01565bf59d038f3be1566da036c60397) |
| Comment by Githook User [ 23/Sep/20 ] |
|
Author: {'name': 'Ali Mir', 'email': 'ali.mir@mongodb.com', 'username': 'ali-mir'}Message: |