[SERVER-51122] [v4.4] The snapshot window code must use TestingProctor consistently and not getTestCommandsEnabled Created: 24/Sep/20 Updated: 29/Oct/23 Resolved: 19/Nov/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Storage |
| Affects Version/s: | None |
| Fix Version/s: | 4.4.3 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Dianna Hohensee (Inactive) | Assignee: | Dianna Hohensee (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||
| Operating System: | ALL | ||||||||||||
| Sprint: | Execution Team 2020-11-16, Execution Team 2020-11-30 | ||||||||||||
| Participants: | |||||||||||||
| Linked BF Score: | 25 | ||||||||||||
| Description |
|
The code currently works because we most often have both TestingProctor and getTestCommandsEnabled enabled. This issue was found when a test suite encountered a bug such that TestingProctor was disabled when it shouldn't have been. This invariant was hit (because of the bug) while this invariant was OK, allowing the window size to increase and cause the first invariant to eventually fire. TestingProctor was recently introduced to the codebase and is now the proper choice for this use case. |
| Comments |
| Comment by Dianna Hohensee (Inactive) [ 19/Nov/20 ] |
|
I used the wrong SERVER number -------------------------------------------------------------------------------------------- Author: {'name': 'Dianna Hohensee', 'email': 'dianna.hohensee@mongodb.com', 'username': 'DiannaHohensee'}Message: |