[SERVER-51163] Mark nodes returning InvalidReplicaSetConfig in heartbeats as down Created: 25/Sep/20 Updated: 29/Oct/23 Resolved: 09/Oct/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Replication |
| Affects Version/s: | None |
| Fix Version/s: | 4.9.0, 4.4.2, 4.2.13, 4.0.24 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Siyuan Zhou | Assignee: | Siyuan Zhou |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||
| Backport Requested: |
v4.4, v4.2, v4.0
|
||||||||||||||||
| Sprint: | Repl 2020-10-05, Repl 2020-10-19 | ||||||||||||||||
| Participants: | |||||||||||||||||
| Linked BF Score: | 47 | ||||||||||||||||
| Description |
|
The sender of heartbeats requests doesn't mark the nodes that return InvalidReplicaSetConfig errors as down or up, the state of that node remains the previous state - Unknown or Down. We should mark the node as down while keeping sending heartbeats to it. Original description: Currently a removed node responds InvalidReplicaSetConfig to heartbeat requests. However that cannot be distinguished from real invalid replica set configs, so that disallow_adding_initialized_node2.js has to keep sending heartbeats even if the config is invalid. We could also give it a new error code if we think NodeNotFound is not descriptive. |
| Comments |
| Comment by Githook User [ 11/Mar/21 ] |
|
Author: {'name': 'Xuerui Fa', 'email': 'xuerui.fa@mongodb.com', 'username': 'XueruiFa'}Message: (cherry picked from commit 418c61279986a5eaddc66a16b5e288556ad1f6d3)
(cherry picked from commit 28c6948a2a02760a69aaee3875c4b2a427528a5a) |
| Comment by Githook User [ 24/Feb/21 ] |
|
Author: {'name': 'Siyuan Zhou', 'email': 'siyuan.zhou@mongodb.com', 'username': 'visualzhou'}Message: (cherry picked from commit 28c6948a2a02760a69aaee3875c4b2a427528a5a) |
| Comment by Githook User [ 15/Oct/20 ] |
|
Author: {'name': 'A. Jesse Jiryu Davis', 'email': 'jesse@mongodb.com', 'username': 'ajdavis'}Message: (cherry picked from commit 418c61279986a5eaddc66a16b5e288556ad1f6d3)
(cherry picked from commit 28c6948a2a02760a69aaee3875c4b2a427528a5a) |
| Comment by Githook User [ 09/Oct/20 ] |
|
Author: {'name': 'Siyuan Zhou', 'email': 'siyuan.zhou@mongodb.com', 'username': 'visualzhou'}Message: |
| Comment by Tess Avitabile (Inactive) [ 28/Sep/20 ] |
|
siyuan.zhou, that sounds good to me. Thank you! |
| Comment by Siyuan Zhou [ 28/Sep/20 ] |
|
tess.avitabile, I could assign this to me for this week rather than scheduling next week, since this failed more than 47 times. I could replace |