[SERVER-51314] Rename hangUpOnStepDown flag for hello command Created: 02/Oct/20 Updated: 06/Dec/22 |
|
| Status: | Backlog |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Matthew Russotto | Assignee: | Backlog - Replication Team |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | former-quick-wins, neweng | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Assigned Teams: |
Replication
|
| Participants: |
| Description |
|
We never hang up on step down any more, just on REMOVED and ROLLBACK. We didn't change the name of the flag for compatibility reasons, but maybe we can when we're sending "hello"? |
| Comments |
| Comment by Tess Avitabile (Inactive) [ 29/Oct/20 ] |
|
Since isMaster/hello ignore unknown parameters, I think we can do this at any time, and we don't need to tie it to the new hello command. In the first release, we accept both hangUpOnStepDown and the new parameter (e.g. hangUpOnRollbackAndRemoved). In the second release, nodes use the new parameter for internal isMaster/hello requests. I believe the hangUpOnStepDown parameter is only used for internal requests. |