[SERVER-51416] improve appendSetParameterArgs version checks in servers.js Created: 07/Oct/20  Updated: 29/Oct/23  Resolved: 09/Oct/20

Status: Closed
Project: Core Server
Component/s: Testing Infrastructure
Affects Version/s: None
Fix Version/s: 4.9.0

Type: Improvement Priority: Major - P3
Reporter: Benety Goh Assignee: Benety Goh
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to SERVER-19837 Cleanup appendSetParameterArgs Backlog
Backwards Compatibility: Fully Compatible
Sprint: Execution Team 2020-10-19
Participants:

 Description   

The version checks for filtering the setParameter key-value pairs for starting up mongod and mongos binaries in tests is done in appendSetParameterArgs() in servers.js. The current state of the version checks can be a little hard to parse because we have to check if we are dealing with the latest version of the binary (!programMajorMinorVersion) or a previous binary version ({e.g. {programMajorMinorVersion >= 440}}). It would be nice to find a way to make these checks easier to understand.



 Comments   
Comment by Githook User [ 09/Oct/20 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-51416 simplify setParameter version checks in servers.js
Branch: master
https://github.com/mongodb/mongo/commit/38e26ada6d76577f261305d32534398dedfd283e

Generated at Thu Feb 08 05:25:25 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.