[SERVER-51421] Unittest runtime in commit-queue is higher than normal Created: 07/Oct/20 Updated: 29/Oct/23 Resolved: 12/Oct/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Testing Infrastructure |
| Affects Version/s: | None |
| Fix Version/s: | 4.9.0 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | David Bradford (Inactive) | Assignee: | [DO NOT ASSIGN] Backlog - Server Development Platform Team (SDP) (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Assigned Teams: |
Server Development Platform
|
| Backwards Compatibility: | Fully Compatible |
| Operating System: | ALL |
| Participants: |
| Description |
|
The unittest runtime is the commit-queue has increased by a large amount since last week. A run from this morning hit almost 2 hours. Previously we were seeing runtimes of around 10-20 minutes with a few spikes around 40 minutes. |
| Comments |
| Comment by Andrew Morrow (Inactive) [ 04/Jan/21 ] |
|
Glad to hear the issues got resolved. In general, I think we want to try hard to keep the unit tests in the queue since otherwise the pressure to keep them super stable sort of comes off, and that just allows new issues to creep in during the window where we weren't running them. That said, I understand that sometimes things are real obstacles to developer forward progress, and it sounds like this was such an instance. |
| Comment by David Bradford (Inactive) [ 04/Jan/21 ] |
|
There have been a bunch of reliability issues around unittest that has made it difficult to pull them in. It looks like those have recently been resolved and unittest results have been pretty stable. So it looks like we are safe to pull them back in now. I can go ahead and do that now. |
| Comment by Andrew Morrow (Inactive) [ 04/Jan/21 ] |
|
david.bradford - That's unfortunate that we had to disable them. Was a follow-up ticket to re-enable them filed? |
| Comment by David Bradford (Inactive) [ 25/Nov/20 ] |
|
This ticket was specifically to address the runtime of the unit tests, which has been resolved. Unfortunately, there have also been a lot of (unrelated) reliability issues introduced to the unittests as well, which makes it difficult to pull it back into the commit-queue until they are resolved. It looks like BF-19017 is causing at least some of the unreliability. Once that has been resolved, we can look at pulling the unittests back into the commit queue. |
| Comment by Max Hirschhorn [ 25/Nov/20 ] |
david.bradford, april.schoffer, was the resolution here to stop running unittests in the commit queue? David Bradford's email had made it sound like the decision to disable it was only a temporary one. |
| Comment by April Schoffer [ 12/Oct/20 ] |
|
Closing given this is now resolved. |