[SERVER-51480] Clear circular dependency of shared_ptr in StreamableReplicaSetMonitor by changing the TopologyListenerPtr Created: 09/Oct/20 Updated: 29/Oct/23 Resolved: 22/Oct/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 4.9.0 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Andrew Shuvalov (Inactive) | Assignee: | Andrew Shuvalov (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Sprint: | Sharding 2020-10-19, Sharding 2020-11-02 | ||||||||
| Participants: | |||||||||
| Description |
|
This is already fixed and it seems like finally passing all tests that I've run (though it's possible some new tests will fail). The idea is that the StreamableReplicaSetMonitor is dangling unless explicitly terminated because the topology events publisher holds it as a shared_ptr, but is owned by the class itself. Cleaning this is the prerequisite for fixing SERVER-50189 and |
| Comments |
| Comment by Githook User [ 19/Oct/20 ] |
|
Author: {'name': 'Andrew Shuvalov', 'email': 'andrew.shuvalov@mongodb.com', 'username': 'shuvalov-mdb'}Message: |