[SERVER-51597] Don't try to cleanly shut down initial syncer when config changes Created: 14/Oct/20  Updated: 29/Oct/23  Resolved: 19/Oct/20

Status: Closed
Project: Core Server
Component/s: Replication
Affects Version/s: None
Fix Version/s: 4.4.2

Type: Bug Priority: Major - P3
Reporter: Matthew Russotto Assignee: Matthew Russotto
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Problem/Incident
causes SERVER-51726 Maintain status code compatibility wh... Closed
Related
is related to SERVER-50320 Fix cancellation races in initial syncer Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Repl 2020-10-19, Repl 2020-11-02
Participants:
Linked BF Score: 46

 Description   

In 4.4 (but no other version), we kill the syncing node with a LOG_FATAL when an initial sync is happening and it is removed from the configuration. We attempt to cleanly shut down the initial syncer first. However, if this results in the initial syncer running out of attempts, we will instead get a LOG_FATAL with that error instead.

We should just LOG_FATAL with the error about being removed; there's no point in trying to cleanly shut down when we're going to kill the server anyway.

(This was uncovered when cancellation of the initial syncer was fixed by SERVER-50320)



 Comments   
Comment by Githook User [ 16/Oct/20 ]

Author:

{'name': 'Matthew Russotto', 'email': 'matthew.russotto@mongodb.com', 'username': 'mtrussotto'}

Message: SERVER-51597 Don't try to cleanly shut down initial syncer when config changes
Branch: v4.4
https://github.com/mongodb/mongo/commit/429d17e6387749db183abf677902660a30c11436

Generated at Thu Feb 08 05:25:55 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.