[SERVER-52516] Make LockManager a ServiceContext decoration Created: 30/Oct/20  Updated: 29/Oct/23  Resolved: 10/Jun/21

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 5.1.0-rc0

Type: Improvement Priority: Major - P3
Reporter: Benjamin Caimano (Inactive) Assignee: Benety Goh
Resolution: Fixed Votes: 0
Labels: newgrad
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
is depended on by SERVER-52515 Remove PeriodicTask Closed
Related
related to SERVER-58278 remove globalLockManager wrapper for ... Closed
is related to SERVER-45266 Move all StorageGlobalParams to be pa... Backlog
Backwards Compatibility: Fully Compatible
Sprint: Execution Team 2021-06-14
Participants:

 Description   

LockManager is accessed via a process global here and is used by a pre-init PeriodicTask here. We should change LockManager to be a ServiceContext decoration and rewrite that PeriodicTask as a PeriodicJob. This will limit use of the LockManager to the lifetime of the ServiceContext.



 Comments   
Comment by Vivian Ge (Inactive) [ 06/Oct/21 ]

Updating the fixversion since branching activities occurred yesterday. This ticket will be in rc0 when it’s been triggered. For more active release information, please keep an eye on #server-release. Thank you!

Comment by Githook User [ 09/Jun/21 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-52516 lockInfo command accesses lock manager as ServiceContext decorator
Branch: master
https://github.com/mongodb/mongo/commit/3fa68a13a30b14392e9297daeab1904f4409daa4

Comment by Githook User [ 09/Jun/21 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-52516 redirect global lock manager accessor to service context decorator

'globalLockManager' will be retained for backwards compatibility with debugger scripts.
Branch: master
https://github.com/mongodb/mongo/commit/f852a4786efb9cf2a2a78ebbf0cabf637d45182c

Comment by Githook User [ 09/Jun/21 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-52516 redirect LockerImpl to access lock manager through getGlobalLockManager()

The globalLockManager will be redefined as a wrapper for debugger scripts.
Branch: master
https://github.com/mongodb/mongo/commit/b31b392135d4d17eb282efe4165185b204289c80

Comment by Githook User [ 09/Jun/21 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-52516 make LockManager an inactive ServiceContext decoration

The global lock manager will be redirected to the ServiceContext decorator shortly.
Branch: master
https://github.com/mongodb/mongo/commit/520df29cd40aabd43debe9452929da1f93b3620a

Comment by Connie Chen [ 05/Nov/20 ]

May need to update GDB or debugger helpers.

Generated at Thu Feb 08 05:28:16 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.