[SERVER-52626] Remove incompatible_with_lockfreereads JS tag Created: 04/Nov/20  Updated: 29/Oct/23  Resolved: 08/Jan/21

Status: Closed
Project: Core Server
Component/s: Storage
Affects Version/s: None
Fix Version/s: 4.9.0

Type: Task Priority: Major - P3
Reporter: Dianna Hohensee (Inactive) Assignee: Henrik Edin
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Problem/Incident
is caused by SERVER-51319 Check DatabaseShardingState::checkDbV... Closed
is caused by SERVER-51677 MaybeLockFree helpers should check di... Closed
Backwards Compatibility: Fully Compatible
Sprint: Execution Team 2020-12-28, Execution Team 2021-01-11, Execution Team 2021-01-25
Participants:
Linked BF Score: 0

 Description   

The tag was temporarily added to jstests/core/crud_ops_do_not_throw_locktimeout.js to unblock progress, but must be revisited. That test runs a find cmd and expects it to block on a collection MODE_X lock, which can't happen with lock-free reads. We probably need to remove the find cmd testing from that JS test, as global MODE_X locks are only held for shutdown, startup and rollback operations, none of which we can provoke to run concurrently with find cmds.



 Comments   
Comment by Ian Whalen (Inactive) [ 09/Jan/21 ]

Author:

{'username': u'evrg-bot-webhook', 'name': u'Dianna Hohensee', 'email': u'dianna.hohensee@mongodb.com'}

Message:SERVER-52626 remove incomaptible_with_lockfreereads tag from sharding_statistics_server_status.js
Branch:master
https://github.com/mongodb/mongo/commit/8ebbd5f2ed1e8316253f0e83f52f0beac5beb8ab

Comment by Henrik Edin [ 08/Jan/21 ]

Closing this. The tag still exists as the test that verifies that the feature flag works is incompatible with builders that override it. 

Comment by Ian Whalen (Inactive) [ 07/Jan/21 ]

Author:

{'username': u'evrg-bot-webhook', 'name': u'Henrik Edin', 'email': u'henrik.edin@mongodb.com'}

Message:SERVER-52626 Check for Lock Free Reads feature flag in crud_ops_do_not_throw_locktimeout.js and make find result conditional on that.
Branch:master
https://github.com/mongodb/mongo/commit/2cbe7e254e1ee2216b6f4600e2f698943b5315ca

Comment by Dianna Hohensee (Inactive) [ 07/Dec/20 ]

Adding the tag (via SERVER-51319) to jstests/sharding/sharding_statistics_server_status.js to investigate later. It's hanging here because it expects a read to hold a lock and stall a migration. I considered making the read part of a transaction to work around LFRs, but it didn't appear to work and I ceased investigation.

Generated at Thu Feb 08 05:28:33 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.