[SERVER-52648]  Refactor kms_aws.cpp into kms_aws.cpp and kms_network.cpp Created: 05/Nov/20  Updated: 15/Mar/21  Resolved: 16/Nov/20

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 4.9.0

Type: Task Priority: Major - P3
Reporter: Mark Benvenuto Assignee: Adam Cooper (Inactive)
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Problem/Incident
Sprint: Security 2020-11-16, Security 2020-11-30
Participants:
Linked BF Score: 0

 Description   

Much of the code in kms_aws.cpp is generic code for

  • Synchronous TLS connections
  • Using kms_message to make and receive requests


 Comments   
Comment by Githook User [ 15/Mar/21 ]

Author:

{'name': 'Adam Cooper', 'email': 'adam.cooper@mongodb.com', 'username': 'super-cooper'}

Message: SERVER-52648 Refactor kms_aws.cpp into kms_aws.cpp and kms_network.cpp

This commit fixes the build failure on Windows which was introduced by the original commit on November 13th, 2020.

(cherry picked from commit 96ced1dddcb87b0bc7bafc40094d9014c04edd98)
Branch: v4.4
https://github.com/mongodb/mongo/commit/c70cdd4dab05881bec7fa150c96d1a9034e3ad50

Comment by Githook User [ 16/Nov/20 ]

Author:

{'name': 'Adam Cooper', 'email': 'adam.cooper@mongodb.com', 'username': 'super-cooper'}

Message: SERVER-52648 Refactor kms_aws.cpp into kms_aws.cpp and kms_network.cpp

This commit fixes the build failure on Windows which was introduced by the original commit on November 13th, 2020.
Branch: master
https://github.com/mongodb/mongo/commit/96ced1dddcb87b0bc7bafc40094d9014c04edd98

Comment by Githook User [ 14/Nov/20 ]

Author:

{'name': 'Adam Cooper', 'email': 'adam.cooper@mongodb.com', 'username': 'super-cooper'}

Message: Revert "SERVER-52648 Refactor kms_aws.cpp into kms_aws.cpp and kms_network.cpp"

This reverts commit a089a4fc13a0395f2d1bb3c71460ac74adb8029d.
Branch: master
https://github.com/mongodb/mongo/commit/ef9fba4d479fdd50f85b73e6171e1dd9a76368b9

Comment by Githook User [ 13/Nov/20 ]

Author:

{'name': 'Adam Cooper', 'email': 'adam.cooper@mongodb.com', 'username': 'super-cooper'}

Message: SERVER-52648 Refactor kms_aws.cpp into kms_aws.cpp and kms_network.cpp
Branch: master
https://github.com/mongodb/mongo/commit/a089a4fc13a0395f2d1bb3c71460ac74adb8029d

Generated at Thu Feb 08 05:28:37 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.