[SERVER-52658] Shut down the Grid's executor before shutting down the PrimaryOnlyServiceRegistry in resharding unit tests Created: 06/Nov/20 Updated: 29/Oct/23 Resolved: 11/Nov/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Sharding |
| Affects Version/s: | None |
| Fix Version/s: | 4.9.0 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Blake Oler | Assignee: | Blake Oler |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | PM-234-M1, PM-234-T-lifecycle | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||
| Sprint: | Sharding 2020-11-16 | ||||||||||||
| Participants: | |||||||||||||
| Linked BF Score: | 0 | ||||||||||||
| Description |
|
In all unit tests, the PrimaryOnlyServiceRegistry must be shut down after the executor. This is so that any pending network calls will be canceled. This will be a temporary stop-gap solution inside the child-level unit test classes. A more robust, systemic solution is detailed in a related ticket and will be completed later. |
| Comments |
| Comment by Githook User [ 10/Nov/20 ] |
|
Author: {'name': 'Blake Oler', 'email': 'blake.oler@mongodb.com', 'username': 'BlakeIsBlake'}Message: |
| Comment by Blake Oler [ 10/Nov/20 ] |
|
Hey daniel.gottlieb, I don't think that the underlying BF for this ticket is related to yours. My problem is specifically with the executor shutting down after the PrimaryOnlyService shuts down. Your problem is the inverse – the executor is already gone by the time that stepup runs. I would say that they're related categorically, but that's about it. |