[SERVER-52807] libraries should inherit the AIB_COMPONENT of their dependers Created: 12/Nov/20  Updated: 28/Aug/23  Resolved: 28/Aug/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Major - P3
Reporter: Daniel Moody Assignee: [DO NOT ASSIGN] Backlog - Server Development Platform Team (SDP) (Inactive)
Resolution: Won't Do Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to SERVER-25822 Prohibit linking unittest library int... Closed
Assigned Teams:
Server Development Platform
Participants:

 Description   

From SERVER-25822, we installed a way to guard certain components linking together. However it's not very effective as most libraries and programs are not labeled for any given component, and it seems that the libraries are not inheriting the AIB_COMPONENT from the top level binaries which are mostly labeled.

 

It should be that the libraries will inherit the AIB_COMPONENT for any binary that is labeled that links with them.
 



 Comments   
Comment by Andrew Morrow (Inactive) [ 04/Jan/21 ]

FYI here is where component inheritance is supposed to happen: https://github.com/mongodb/mongo/blob/f012be046c8a16fe80ca3c08ee19a48931feb696/site_scons/site_tools/auto_install_binaries.py#L289-L302, but the logic is not correct.

Comment by Andrew Morrow (Inactive) [ 04/Jan/21 ]

It is a deliberate design decision in AIB that not all libraries should need explicit tagging. The answer is supposed to be that libraries inherit components via a component inheritance mechanism. However, that mechanism is incorrectly implemented. The first step should be to properly implement component inheritance, and see if that gets us far enough along.

Generated at Thu Feb 08 05:29:04 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.