[SERVER-52872] Remove StatusWith methods from ShardingCatalogClient Created: 16/Nov/20  Updated: 29/Oct/23  Resolved: 20/Nov/20

Status: Closed
Project: Core Server
Component/s: Sharding
Affects Version/s: None
Fix Version/s: 4.9.0

Type: Improvement Priority: Major - P3
Reporter: Kaloian Manassiev Assignee: Kaloian Manassiev
Resolution: Fixed Votes: 0
Labels: PM-1965-Cleanup
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Sprint: Sharding 2020-11-30
Participants:

 Description   

The ShardingCatalogClient uses both StatusWith and exception-throwing methods, which is potential source of bugs and also adds code verbosity. This ticket is to switch entirely to exception-throwing methods, which will also allow some of the parsing code to be thrown out (namely the fromBSON methods like this one), simplifying the work for SERVER-52776.



 Comments   
Comment by Githook User [ 16/Nov/20 ]

Author:

{'name': 'Kaloian Manassiev', 'email': 'kaloian.manassiev@mongodb.com', 'username': 'kaloianm'}

Message: SERVER-52872 Remove StatusWith methods from ShardingCatalogClient

As a side-effect also removes some of the legacy "fromBSON" parsing from
CollectionType in an effort to make it behave more IDL-like.
Branch: master
https://github.com/mongodb/mongo/commit/a2fb8664bfc09a7b970f5de8188b4478ff64fc23

Generated at Thu Feb 08 05:29:15 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.