[SERVER-52976] [4.2] collection_validation.cpp isn't used anywhere in the 4.2 branch Created: 20/Nov/20  Updated: 29/Oct/23  Resolved: 12/Oct/21

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: 4.2.11
Fix Version/s: 4.2.18

Type: Improvement Priority: Minor - P4
Reporter: Mihai Andrei Assignee: Benety Goh
Resolution: Fixed Votes: 0
Labels: neweng, techdebt
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to SERVER-42312 Validate during rollback can cause co... Closed
is related to SERVER-43081 validate should report when an index'... Closed
Backwards Compatibility: Fully Compatible
Sprint: Execution Team 2021-10-18
Participants:
Linked BF Score: 8

 Description   

collection_validation.cpp isn't used anywhere in the 4.2 branch; it simply appears to duplicate the 'validate' command logic in collection_impl.cpp. The file should either be removed or the duplicated logic should be removed from collection_impl.cpp and collection_validation.cpp should be included within db/catalog/SConscript.



 Comments   
Comment by Githook User [ 11/Oct/21 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-52976 remove unused file collection_validation.cpp

The validation improvement in commit 719513a440fdd5a4b97bdab3bbf0e9748678f3a8, which introduced
this unused file, can be found in the function _validateCatalogEntry() (collection_impl.cpp).

The replication state check in commit 186079301dc9de56313f5a8e84e6088fec289ded has been moved
to CollectionImpl::validate() (colletion_impl.cpp) in commit 3ac74aad2a2b70ad5b1ccb97b07a92c52a51f2f3.
Branch: v4.2
https://github.com/mongodb/mongo/commit/4da49024045ef47a6958157b64e73511c4865b49

Comment by Githook User [ 11/Oct/21 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-52976 SERVER-42312 disallow validate cmd during rollback and recovering states

(cherry picked from commit 1a3936b3ee365de5dde80e440c01fa6e868a1a54)
(cherry picked from commit 82e34b0d86c6625b5a67d1909e1dcc434f78be82)
Branch: v4.2
https://github.com/mongodb/mongo/commit/3ac74aad2a2b70ad5b1ccb97b07a92c52a51f2f3

Comment by Benety Goh [ 04/Oct/21 ]

Need to revisit backports for SERVER-43801 and SERVER-42312 before removing the file.

Generated at Thu Feb 08 05:29:35 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.