[SERVER-52976] [4.2] collection_validation.cpp isn't used anywhere in the 4.2 branch Created: 20/Nov/20 Updated: 29/Oct/23 Resolved: 12/Oct/21 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | 4.2.11 |
| Fix Version/s: | 4.2.18 |
| Type: | Improvement | Priority: | Minor - P4 |
| Reporter: | Mihai Andrei | Assignee: | Benety Goh |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | neweng, techdebt | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||
| Sprint: | Execution Team 2021-10-18 | ||||||||||||
| Participants: | |||||||||||||
| Linked BF Score: | 8 | ||||||||||||
| Description |
|
collection_validation.cpp isn't used anywhere in the 4.2 branch; it simply appears to duplicate the 'validate' command logic in collection_impl.cpp. The file should either be removed or the duplicated logic should be removed from collection_impl.cpp and collection_validation.cpp should be included within db/catalog/SConscript. |
| Comments |
| Comment by Githook User [ 11/Oct/21 ] |
|
Author: {'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}Message: The validation improvement in commit 719513a440fdd5a4b97bdab3bbf0e9748678f3a8, which introduced The replication state check in commit 186079301dc9de56313f5a8e84e6088fec289ded has been moved |
| Comment by Githook User [ 11/Oct/21 ] |
|
Author: {'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}Message: (cherry picked from commit 1a3936b3ee365de5dde80e440c01fa6e868a1a54) |
| Comment by Benety Goh [ 04/Oct/21 ] |
|
Need to revisit backports for |