[SERVER-53059] rename to fix spelling Interruptable => Interruptible Created: 24/Nov/20  Updated: 29/Oct/23  Resolved: 08/Dec/20

Status: Closed
Project: Core Server
Component/s: Internal Code
Affects Version/s: None
Fix Version/s: 4.9.0

Type: Improvement Priority: Major - P3
Reporter: Billy Donahue Assignee: Billy Donahue
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Sprint: Service arch 2020-12-14
Participants:

 Description   

The word is "interruptible".
Having a misspelling around creates an inconsistency to keep track of.

Should fix these:

src/mongo/s/query/blocking_results_merger_test.cpp:188:TEST_F(ResultsMergerTestFixture, ShouldBeInterruptableDuringBlockingNext) {
src/mongo/util/fail_point_test.cpp:511:void assertFunctionInterruptable(std::function<void(Interruptible* interruptible)> f) {
src/mongo/util/fail_point_test.cpp:534: assertFunctionInterruptable(
src/mongo/util/fail_point_test.cpp:544: assertFunctionInterruptable([&failPoint](Interruptible* interruptible) {
src/mongo/util/future_test_edge_cases.cpp:193: DummyInterruptable dummyInterruptable;
src/mongo/util/future_test_edge_cases.cpp:196: ASSERT_EQ(pf.future.waitNoThrow(&dummyInterruptable), ErrorCodes::Interrupted);
src/mongo/util/future_test_edge_cases.cpp:197: ASSERT_EQ(pf.future.getNoThrow(&dummyInterruptable), ErrorCodes::Interrupted);
src/mongo/util/future_test_edge_cases.cpp:204: DummyInterruptable dummyInterruptable;
src/mongo/util/future_test_edge_cases.cpp:212: auto res = future.waitNoThrow(&dummyInterruptable);
src/mongo/util/future_test_edge_cases.cpp:217: res = future.getNoThrow(&dummyInterruptable);
src/mongo/util/future_test_edge_cases.cpp:226: DummyInterruptable dummyInterruptable;
src/mongo/util/future_test_edge_cases.cpp:229: ASSERT_EQ(pf.future.waitNoThrow(&dummyInterruptable), ErrorCodes::Interrupted);
src/mongo/util/future_test_edge_cases.cpp:237: DummyInterruptable dummyInterruptable;
src/mongo/util/future_test_edge_cases.cpp:245: auto res = future.waitNoThrow(&dummyInterruptable);
src/mongo/util/future_test_edge_cases.cpp:250: res = future.getNoThrow(&dummyInterruptable);
src/mongo/util/future_test_shared_future.cpp:268: DummyInterruptable dummyInterruptable;
src/mongo/util/future_test_shared_future.cpp:271: auto res = shared.waitNoThrow(&dummyInterruptable);
src/mongo/util/future_test_shared_future.cpp:304: DummyInterruptable dummyInterruptable;
src/mongo/util/future_test_shared_future.cpp:305: auto res = shared.waitNoThrow(&dummyInterruptable);
src/mongo/util/future_test_utils.h:54:class DummyInterruptable final : public Interruptible {
src/mongo/util/interruptible_test.cpp:39:class DummyInterruptable final : public Interruptible {
src/mongo/util/interruptible_test.cpp:74: auto interruptible = std::make_unique<DummyInterruptable>();
src/mongo/util/interruptible_test.cpp:113: auto interruptible = std::make_unique<DummyInterruptable>();



 Comments   
Comment by Githook User [ 08/Dec/20 ]

Author:

{'name': 'Billy Donahue', 'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue'}

Message: SERVER-53059 spelling Interruptable => Interruptible
Branch: master
https://github.com/mongodb/mongo/commit/51660945fb6662367f30e00b1a4685787ad9bd89

Comment by Billy Donahue [ 04/Dec/20 ]

CR https://mongodbcr.appspot.com/718920001/

Generated at Thu Feb 08 05:29:48 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.